Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 137203005: Moved the ProxyPolicyProvider to the policy component. (Closed)

Created:
6 years, 11 months ago by Joao da Silva
Modified:
6 years, 11 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@BPC-3-dm-url-at-base
Visibility:
Public.

Description

Moved the ProxyPolicyProvider to the policy component. This policy provider gets its policies from a delegate policy provider. It is used on ChromeOS to allow user cloud policy to override some prefs in Local State (the providers that override Local State must be ready before the Profile and user policy are ready). After moving to the component it will be possible to enable this provider on iOS builds, so that user cloud policy can override some Local State prefs on that platform too (such as metrics reporting). BUG=275292 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -213 lines) Patch
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/policy/proxy_policy_provider.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/chromeos/policy/proxy_policy_provider.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/chromeos/policy/proxy_policy_provider_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A + components/policy/core/common/proxy_policy_provider.h View 2 chunks +7 lines, -6 lines 0 comments Download
A + components/policy/core/common/proxy_policy_provider.cc View 1 chunk +5 lines, -1 line 0 comments Download
A + components/policy/core/common/proxy_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/policy_common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
PTAL, thanks!
6 years, 11 months ago (2014-01-21 12:47:25 UTC) #1
dconnelly
lgtm
6 years, 11 months ago (2014-01-21 12:58:32 UTC) #2
Joao da Silva
Jochen to TBR for components_tests.gyp
6 years, 11 months ago (2014-01-21 19:48:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/137203005/1
6 years, 11 months ago (2014-01-21 19:48:39 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 21:31:51 UTC) #5
Message was sent while issue was closed.
Change committed as 246116

Powered by Google App Engine
This is Rietveld 408576698