Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1371973002: Revert of Enable errorprone on the chromium.fyi Errorprone Builder (Reland). (Closed)

Created:
5 years, 2 months ago by mikecase (-- gone --)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Enable errorprone on the chromium.fyi Errorprone Builder (Reland). (patchset #1 id:1 of https://codereview.chromium.org/1374653002/ ) Reason for revert: Errorprone still has problems running on the bots :-/ http://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29/builds/59399/steps/compile/logs/stdio Original issue's description: > Enable errorprone on the chromium.fyi Errorprone Builder (Reland). > > Enabling errorprone first on the fyi builder to test if things work. > If everything seems ok, I will make enable_errorprone=1 the default. > > Original CL: https://codereview.chromium.org/1305303002/ > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296897 TBR=phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M scripts/slave/recipe_modules/chromium_android/chromium_config.py View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
mikecase (-- gone --)
Created Revert of Enable errorprone on the chromium.fyi Errorprone Builder (Reland).
5 years, 2 months ago (2015-09-28 10:48:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371973002/1
5 years, 2 months ago (2015-09-28 10:48:29 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-09-28 10:48:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371973002/1
5 years, 2 months ago (2015-09-28 10:50:31 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-09-28 10:50:32 UTC) #8
mikecase (-- gone --)
lgtm
5 years, 2 months ago (2015-09-28 10:50:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371973002/1
5 years, 2 months ago (2015-09-28 10:53:20 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-09-28 10:53:21 UTC) #13
jbudorick
lgtm
5 years, 2 months ago (2015-09-28 10:55:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371973002/1
5 years, 2 months ago (2015-09-28 10:56:10 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 10:56:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296898

Powered by Google App Engine
This is Rietveld 408576698