Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1371963002: [es6] Ship rest parameters. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg, adamk
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Ship rest parameters. R=rossberg BUG= Committed: https://crrev.com/d3ef8f4b9579417d84b65f6dac4c51676a264639 Cr-Commit-Position: refs/heads/master@{#30970}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M src/bootstrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 1 comment Download
M src/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/preparser.h View 4 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/js-perf-test/JSTests.json View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/spread-call.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/spread-call-new.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/spread-call-new-class.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/spread-call-super-property.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/super.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strong/function-arity.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
neis
5 years, 2 months ago (2015-09-28 10:36:11 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-09-28 10:47:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371963002/1
5 years, 2 months ago (2015-09-28 10:50:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 11:17:03 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d3ef8f4b9579417d84b65f6dac4c51676a264639 Cr-Commit-Position: refs/heads/master@{#30970}
5 years, 2 months ago (2015-09-28 11:19:42 UTC) #6
adamk
https://codereview.chromium.org/1371963002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1371963002/diff/1/src/flag-definitions.h#newcode218 src/flag-definitions.h:218: V(harmony_spread_calls, "harmony spread-calls") \ Why did this change? Note ...
5 years, 2 months ago (2015-09-28 18:34:24 UTC) #8
Jakob Kummerow
DBC: While I'm not familiar with the details here, I would generally advise against shipping ...
5 years, 2 months ago (2015-09-28 19:13:33 UTC) #9
rossberg
5 years, 2 months ago (2015-09-29 06:36:19 UTC) #10
Message was sent while issue was closed. 
On 2015/09/28 18:34:24, adamk wrote:
> https://codereview.chromium.org/1371963002/diff/1/src/flag-definitions.h
> File src/flag-definitions.h (right):
> 
>
https://codereview.chromium.org/1371963002/diff/1/src/flag-definitions.h#newc...
> src/flag-definitions.h:218: V(harmony_spread_calls, "harmony spread-calls")   
 
>          \
> Why did this change? Note that this flag will be gone once M46 is in stable.

Yeah, good point. My fault, I suggested this drive-by change. Hopefully it won't
be an issue, though, since the flag is stable.

Powered by Google App Engine
This is Rietveld 408576698