Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1371943002: [heap] Simplify CALL_HEAP_FUNCTION macro dance. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Simplify CALL_HEAP_FUNCTION macro dance. R=hpayer@chromium.org Committed: https://crrev.com/8dc8903f3de553e28d2eee6e9afa0f8ee5c3d24e Cr-Commit-Position: refs/heads/master@{#30973}

Patch Set 1 #

Patch Set 2 : Simplify further. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -23 lines) Patch
M src/heap/heap-inl.h View 1 2 chunks +10 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-09-28 09:20:33 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-09-28 12:50:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371943002/20001
5 years, 2 months ago (2015-09-28 12:53:51 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 12:55:52 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 13:01:57 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8dc8903f3de553e28d2eee6e9afa0f8ee5c3d24e
Cr-Commit-Position: refs/heads/master@{#30973}

Powered by Google App Engine
This is Rietveld 408576698