Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1371933005: MediaStream Recorder: add usage counter to WebRTC.webkitApiCount UMA (Closed)

Created:
5 years, 2 months ago by mcasas
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaStream Recorder: add usage counter to WebRTC.webkitApiCount UMA MediaStream Recorder is a new API and soon will be enabled as WebKit experimental. This CL adds a UMA usage counter as another WebRtc JS call counter. BUG=262211 Committed: https://crrev.com/2f4aeee97410f1d38ec1ca0927a7a71404620bdb Cr-Commit-Position: refs/heads/master@{#351823}

Patch Set 1 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M content/renderer/media/media_recorder_handler.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc_uma_histograms.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc_uma_histograms.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mcasas
asvitkine@ histograms.xml PTAL perkj@ I'm piggybacking on your UMA. PTAL :)
5 years, 2 months ago (2015-09-30 23:32:40 UTC) #3
perkj_chrome
lgtm
5 years, 2 months ago (2015-10-01 10:57:07 UTC) #4
Alexei Svitkine (slow)
lgtm
5 years, 2 months ago (2015-10-01 16:23:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371933005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371933005/20001
5 years, 2 months ago (2015-10-01 16:36:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 2 months ago (2015-10-01 16:42:18 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 16:43:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f4aeee97410f1d38ec1ca0927a7a71404620bdb
Cr-Commit-Position: refs/heads/master@{#351823}

Powered by Google App Engine
This is Rietveld 408576698