Save display preference on boot

Save display preference on boot.
Move the DisplayConfigurationObserver to shell delegate's PreInit which is the right place to do initialization that happens before Shell::Init.

BUG=332852
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245098

[Jun Mukai, 2014-01-13 23:51:15]

https://codereview.chromium.org/137193004/diff/30001/chrome/browser/ui/ash/ch...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://codereview.chromium.org/137193004/diff/30001/chrome/browser/ui/ash/ch...
chrome/browser/ui/ash/chrome_shell_delegate.cc:32: #include
"chrome/browser/chromeos/display/display_configuration_observer.h"
do we need this line?

https://codereview.chromium.org/137193004/diff/30001/chrome/browser/ui/ash/ch...
File chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc (right):

https://codereview.chromium.org/137193004/diff/30001/chrome/browser/ui/ash/ch...
chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc:212: new
chromeos::DisplayConfigurationObserver());
I'm not sure why moving display_configuration_observer_ to ShellDelegate. 
What's the point? Could you describe why on the CL description or a comment?

[oshima, 2014-01-13 23:58:19]

https://codereview.chromium.org/137193004/diff/30001/chrome/browser/ui/ash/ch...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://codereview.chromium.org/137193004/diff/30001/chrome/browser/ui/ash/ch...
chrome/browser/ui/ash/chrome_shell_delegate.cc:32: #include
"chrome/browser/chromeos/display/display_configuration_observer.h"
On 2014/01/13 23:51:15, Jun Mukai wrote:
> do we need this line?

This is necessary to delete DisplayCOnfigurationObserver object.

https://codereview.chromium.org/137193004/diff/30001/chrome/browser/ui/ash/ch...
File chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc (right):

https://codereview.chromium.org/137193004/diff/30001/chrome/browser/ui/ash/ch...
chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc:212: new
chromeos::DisplayConfigurationObserver());
This should happen before Shell::Init so that observer can store the initial
state. I updated the description and added comment.

[Jun Mukai, 2014-01-14 00:48:22]

lgtm
thanks for the explains.

[commit-bot: I haz the power, 2014-01-14 02:31:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/137193004/90001

[commit-bot: I haz the power, 2014-01-14 02:31:31]

Failed to apply patch for
chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
  Hunk #2 FAILED at 208.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc.rej

Patch:       chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
Index: chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
diff --git a/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
b/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
index
8fdfe73cb06a79dec29a53a80b3ca4e5d4f23218..ebc40ac2a870a23076d1b8dbf2da85e347044b86
100644
--- a/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
+++ b/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
@@ -15,6 +15,7 @@
 #include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
 #include "chrome/browser/chromeos/accessibility/magnification_manager.h"
 #include "chrome/browser/chromeos/background/ash_user_wallpaper_delegate.h"
+#include "chrome/browser/chromeos/display/display_configuration_observer.h"
 #include "chrome/browser/chromeos/display/display_preferences.h"
 #include "chrome/browser/chromeos/extensions/media_player_api.h"
 #include "chrome/browser/chromeos/extensions/media_player_event_router.h"
@@ -207,12 +208,20 @@ bool ChromeShellDelegate::IsFirstRunAfterBoot() const {
 
 void ChromeShellDelegate::PreInit() {
   chromeos::LoadDisplayPreferences(IsFirstRunAfterBoot());
+  // Set the observer now so that we can save the initial state
+  // in Shell::Init.
+  display_configuration_observer_.reset(
+      new chromeos::DisplayConfigurationObserver());
 }
 
 void ChromeShellDelegate::Shutdown() {
   content::RecordAction(content::UserMetricsAction("Shutdown"));
   chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->
       RequestShutdown();
+
+  // Let classes unregister themselves as observers of the ash::Shell singleton
+  // before the shell is destroyed.
+  display_configuration_observer_.reset();
 }
 
 ash::CapsLockDelegate* ChromeShellDelegate::CreateCapsLockDelegate() {

[commit-bot: I haz the power, 2014-01-14 08:42:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/137193004/130001

[commit-bot: I haz the power, 2014-01-14 10:03:40]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2014-01-14 18:29:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/137193004/370001

[commit-bot: I haz the power, 2014-01-14 23:26:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/137193004/370001

[commit-bot: I haz the power, 2014-01-15 03:00:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/137193004/370001

[commit-bot: I haz the power, 2014-01-16 03:41:43]

Change committed as 245098