scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json - Issue 1371913005: chromium_tests: add explicit compile targets to bots that need them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json

Issue 1371913005: chromium_tests: add explicit compile targets to bots that need them (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json b/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json

index 4b24946b94526636ad53afd270716c114386dbf7..4810cb72645f4f8e67ed78d0377ac13939f6c560 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json

@@ -121,19 +121,24 @@

"cmd": [

"python",

"-u",

- "import sys; sys.exit(1)"

+ "[BUILD]/scripts/slave/compile.py",

+ "--target",

+ "Release",

+ "--src-dir",

+ "[SLAVE_BUILD]/src",

+ "--build-tool",

+ "ninja",

+ "--compiler",

+ "goma",

+ "--mode",

+ "official",

+ "--goma-dir",

+ "[BUILD]/goma",

+ "--clobber",

+ "--",

+ "linux_packages_all"

"cwd": "[SLAVE_BUILD]",

- "name": "compile",

- "~followup_annotations": [

- "step returned non-zero exit code: 1",

- "@@@STEP_TEXT@Misconfigured bot: no compile targets@@@",

- "@@@STEP_FAILURE@@@"

- ]

- },

- {

- "name": "$final_result",

- "reason": "Step('compile') failed with return_code 1",

- "status_code": 1

+ "name": "compile"

}

]