Material PDF: Adjust behaviour of page selector

chrome/test/data/pdf/material_elements_test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Standalone unit tests of the PDF Polymer elements.
  */
 var tests = [
   /**
    * Test that viewer-page-selector reacts correctly to text entry. The page
-   * selector validates that input is an integer, but does not check for
-   * document bounds.
+   * selector validates that input is an integer, and does not allow navigation
+   * past document bounds.
    */
   function testPageSelectorChange() {
     var selector =
         Polymer.Base.create('viewer-page-selector', {docLength: 1234});
 
     var input = selector.$.input;
     // Simulate entering text into `input` and pressing enter.
     function changeInput(newValue) {
-      input.bindValue = newValue;
+      input.value = newValue;
       input.dispatchEvent(new CustomEvent('change'));
     }
 
     var navigatedPages = [];
     selector.addEventListener('change-page', function(e) {
       navigatedPages.push(e.detail.page);
+      // A change-page handler is expected to set the pageNo to the new value.
+      selector.pageNo = e.detail.page + 1;
     });
 
     changeInput("1000");
     changeInput("1234");
     changeInput("abcd");
-    changeInput("12pp");

[raymes, 2015/10/01 03:02:09]

How come you removed this one?

[tsergeant, 2015/10/01 04:42:22]

Oops, no need for that change anymore. I've added it back.

     changeInput("3.14");
+    changeInput("3000");
 
-    chrome.test.assertEq(4, navigatedPages.length);
+    chrome.test.assertEq(3, navigatedPages.length);
     // The event page number is 0-based.
     chrome.test.assertEq(999, navigatedPages[0]);
     chrome.test.assertEq(1233, navigatedPages[1]);
-    chrome.test.assertEq(11, navigatedPages[2]);
-    chrome.test.assertEq(2, navigatedPages[3]);
+    chrome.test.assertEq(2, navigatedPages[2]);
 
     chrome.test.succeed();
   },
 
   /**
    * Test that viewer-page-selector changes in response to setting docLength.
    */
   function testPageSelectorDocLength() {
     var selector =
         Polymer.Base.create('viewer-page-selector', {docLength: 1234});
@@ skipping 121 matching lines @@
     MockInteractions.tap(fab);
     assertEvent('fit-to-page');
 
     chrome.test.succeed();
   }
 ];
 
 importTestHelpers().then(function() {
   chrome.test.runTests(tests);
 });