Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1371863002: Android: Do not build files not needed on the platform. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Do not build files not needed on the platform. This gives us the size decreases from https://crbug.com/159847#c39 BUG=159847 Committed: https://crrev.com/354985dafcc1132adf566c521b7611f415c2d011 Cr-Commit-Position: refs/heads/master@{#351137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -43 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 6 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 15 chunks +22 lines, -28 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 3 chunks +21 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
5 years, 2 months ago (2015-09-28 02:33:23 UTC) #2
sky
LGTM
5 years, 2 months ago (2015-09-28 15:11:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371863002/1
5 years, 2 months ago (2015-09-28 17:18:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 20:55:08 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 20:56:07 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/354985dafcc1132adf566c521b7611f415c2d011
Cr-Commit-Position: refs/heads/master@{#351137}

Powered by Google App Engine
This is Rietveld 408576698