Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1371853003: Add a Layout Test for the fix a use-after-free in CSSImageSetValue. (Closed)

Created:
5 years, 2 months ago by nainar
Modified:
5 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a Layout Test for the fix a use-after-free in CSSImageSetValue. BUG=535460, 534993 Committed: https://crrev.com/6936189c4a35f9431749fe2d13fd8920129d004d Cr-Commit-Position: refs/heads/master@{#351041}

Patch Set 1 #

Patch Set 2 : Test for serialization #

Patch Set 3 : Change message and indents #

Patch Set 4 : Rebase test #

Patch Set 5 : Rebase test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/cssimagesetvalue-crash.html View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
nainar
Tim, PTAL? Thanks!
5 years, 2 months ago (2015-09-28 06:15:53 UTC) #2
Timothy Loh
On 2015/09/28 06:15:53, nainar wrote: > Tim, > > PTAL? > > Thanks! lgtm
5 years, 2 months ago (2015-09-28 06:16:57 UTC) #3
Timothy Loh
On 2015/09/28 06:16:57, Timothy Loh wrote: > On 2015/09/28 06:15:53, nainar wrote: > > Tim, ...
5 years, 2 months ago (2015-09-28 06:17:17 UTC) #4
nainar
Tim, added the test for serialization, PTAL? Thanks!
5 years, 2 months ago (2015-09-28 06:51:24 UTC) #5
Timothy Loh
On 2015/09/28 06:51:24, nainar wrote: > Tim, > > added the test for serialization, PTAL? ...
5 years, 2 months ago (2015-09-28 07:07:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371853003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371853003/40001
5 years, 2 months ago (2015-09-28 07:14:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371853003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371853003/80001
5 years, 2 months ago (2015-09-28 08:14:05 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-09-28 09:07:41 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 09:08:55 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6936189c4a35f9431749fe2d13fd8920129d004d
Cr-Commit-Position: refs/heads/master@{#351041}

Powered by Google App Engine
This is Rietveld 408576698