Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1371823002: Fix compilation with GCC 5.2 (Closed)

Created:
5 years, 2 months ago by skomski
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix compilation with GCC 5.2 Fixes: ../../test/cctest/compiler/test-js-typed-lowering.cc:224:14: error: ‘kJSTypes’ defined but not used [-Werror=unused-variable] static Type* kJSTypes[] = {Type::Undefined(), Type::Null(), Type::Boolean(), ../../src/bignum.cc: In member function ‘void v8::internal::Bignum::AssignDecimalString(Vector<const char>)’: ../../src/bignum.cc:80:6: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow] ../../src/compiler/ia32/code-generator-ia32.cc:1366:3: required from here ../../src/base/logging.h:123:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] DEFINE_CHECK_OP_IMPL(EQ, ==) BUG= Committed: https://crrev.com/e28183b5977a2d2732f7f8b9a2f26637c9566585 Cr-Commit-Position: refs/heads/master@{#31095}

Patch Set 1 #

Patch Set 2 : fix debug compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/bignum.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371823002/1
5 years, 2 months ago (2015-09-26 20:26:37 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-09-26 20:26:38 UTC) #4
skomski
5 years, 2 months ago (2015-10-05 08:59:24 UTC) #6
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-05 10:18:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371823002/20001
5 years, 2 months ago (2015-10-05 10:43:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-05 11:07:27 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 11:07:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e28183b5977a2d2732f7f8b9a2f26637c9566585
Cr-Commit-Position: refs/heads/master@{#31095}

Powered by Google App Engine
This is Rietveld 408576698