Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: content/renderer/usb/web_usb_client_impl.cc

Issue 1371793004: Provide the DeviceManager service to the renderer directly, no app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@interface_permission
Patch Set: Fix chrome_browser.gypi. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/usb/web_usb_client_impl.h ('k') | device/devices_app/devices_app.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/usb/web_usb_client_impl.h" 5 #include "content/renderer/usb/web_usb_client_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/move.h" 10 #include "base/move.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "content/child/scoped_web_callbacks.h" 12 #include "content/child/scoped_web_callbacks.h"
13 #include "content/public/common/service_registry.h"
13 #include "content/renderer/usb/type_converters.h" 14 #include "content/renderer/usb/type_converters.h"
14 #include "content/renderer/usb/web_usb_device_impl.h" 15 #include "content/renderer/usb/web_usb_device_impl.h"
15 #include "device/devices_app/public/cpp/constants.h"
16 #include "mojo/application/public/cpp/connect.h"
17 #include "mojo/application/public/interfaces/shell.mojom.h"
18 #include "third_party/WebKit/public/platform/WebCallbacks.h" 16 #include "third_party/WebKit/public/platform/WebCallbacks.h"
19 #include "third_party/WebKit/public/platform/WebPassOwnPtr.h" 17 #include "third_party/WebKit/public/platform/WebPassOwnPtr.h"
20 #include "third_party/WebKit/public/platform/modules/webusb/WebUSBDeviceFilter.h " 18 #include "third_party/WebKit/public/platform/modules/webusb/WebUSBDeviceFilter.h "
21 #include "third_party/WebKit/public/platform/modules/webusb/WebUSBDeviceInfo.h" 19 #include "third_party/WebKit/public/platform/modules/webusb/WebUSBDeviceInfo.h"
22 #include "third_party/WebKit/public/platform/modules/webusb/WebUSBDeviceRequestO ptions.h" 20 #include "third_party/WebKit/public/platform/modules/webusb/WebUSBDeviceRequestO ptions.h"
23 #include "third_party/WebKit/public/platform/modules/webusb/WebUSBError.h" 21 #include "third_party/WebKit/public/platform/modules/webusb/WebUSBError.h"
24 #include "third_party/mojo/src/mojo/public/cpp/bindings/array.h" 22 #include "third_party/mojo/src/mojo/public/cpp/bindings/array.h"
25 #include "third_party/mojo/src/mojo/public/cpp/bindings/interface_request.h" 23 #include "third_party/mojo/src/mojo/public/cpp/bindings/interface_request.h"
26 24
27 namespace content { 25 namespace content {
(...skipping 18 matching lines...) Expand all
46 CallbacksType* callbacks) { 44 CallbacksType* callbacks) {
47 return make_scoped_web_callbacks( 45 return make_scoped_web_callbacks(
48 callbacks, 46 callbacks,
49 base::Bind(&RejectCallbacksWithError<CallbacksType>, 47 base::Bind(&RejectCallbacksWithError<CallbacksType>,
50 blink::WebUSBError(blink::WebUSBError::Error::Service, 48 blink::WebUSBError(blink::WebUSBError::Error::Service,
51 base::UTF8ToUTF16(kNoServiceError)))); 49 base::UTF8ToUTF16(kNoServiceError))));
52 } 50 }
53 51
54 void OnGetDevicesComplete( 52 void OnGetDevicesComplete(
55 ScopedWebCallbacks<blink::WebUSBClientGetDevicesCallbacks> scoped_callbacks, 53 ScopedWebCallbacks<blink::WebUSBClientGetDevicesCallbacks> scoped_callbacks,
56 mojo::ServiceProvider* device_services, 54 device::usb::DeviceManager* device_manager,
57 mojo::Array<device::usb::DeviceInfoPtr> results) { 55 mojo::Array<device::usb::DeviceInfoPtr> results) {
58 device::usb::DeviceManagerPtr device_manager;
59 mojo::ConnectToService(device_services, &device_manager);
60 blink::WebVector<blink::WebUSBDevice*>* devices = 56 blink::WebVector<blink::WebUSBDevice*>* devices =
61 new blink::WebVector<blink::WebUSBDevice*>(results.size()); 57 new blink::WebVector<blink::WebUSBDevice*>(results.size());
62 for (size_t i = 0; i < results.size(); ++i) { 58 for (size_t i = 0; i < results.size(); ++i) {
63 device::usb::DevicePtr device; 59 device::usb::DevicePtr device;
64 device_manager->GetDevice(results[i]->guid, mojo::GetProxy(&device)); 60 device_manager->GetDevice(results[i]->guid, mojo::GetProxy(&device));
65 (*devices)[i] = new WebUSBDeviceImpl( 61 (*devices)[i] = new WebUSBDeviceImpl(
66 device.Pass(), mojo::ConvertTo<blink::WebUSBDeviceInfo>(results[i])); 62 device.Pass(), mojo::ConvertTo<blink::WebUSBDeviceInfo>(results[i]));
67 } 63 }
68 scoped_callbacks.PassCallbacks()->onSuccess(blink::adoptWebPtr(devices)); 64 scoped_callbacks.PassCallbacks()->onSuccess(blink::adoptWebPtr(devices));
69 } 65 }
70 66
71 } // namespace 67 } // namespace
72 68
73 WebUSBClientImpl::WebUSBClientImpl(mojo::ServiceProviderPtr device_services) 69 WebUSBClientImpl::WebUSBClientImpl(content::ServiceRegistry* service_registry) {
74 : device_services_(device_services.Pass()) { 70 service_registry->ConnectToRemoteService(mojo::GetProxy(&device_manager_));
75 mojo::ConnectToService(device_services_.get(), &device_manager_); 71 device_manager_.set_connection_error_handler(
72 [this]() { LOG(ERROR) << "Device manager connection failed."; });
76 } 73 }
77 74
78 WebUSBClientImpl::~WebUSBClientImpl() {} 75 WebUSBClientImpl::~WebUSBClientImpl() {}
79 76
80 void WebUSBClientImpl::getDevices( 77 void WebUSBClientImpl::getDevices(
81 blink::WebUSBClientGetDevicesCallbacks* callbacks) { 78 blink::WebUSBClientGetDevicesCallbacks* callbacks) {
82 auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks); 79 auto scoped_callbacks = MakeScopedUSBCallbacks(callbacks);
83 // TODO(rockot): Remove this once DeviceManager is updated. It should no 80 // TODO(rockot): Remove this once DeviceManager is updated. It should no
84 // longer take enumeration options. 81 // longer take enumeration options.
85 device::usb::EnumerationOptionsPtr options = 82 device::usb::EnumerationOptionsPtr options =
86 device::usb::EnumerationOptions::New(); 83 device::usb::EnumerationOptions::New();
87 options->filters = mojo::Array<device::usb::DeviceFilterPtr>::New(0); 84 options->filters = mojo::Array<device::usb::DeviceFilterPtr>::New(0);
88 device_manager_->GetDevices( 85 device_manager_->GetDevices(
89 options.Pass(), 86 options.Pass(),
90 base::Bind(&OnGetDevicesComplete, base::Passed(&scoped_callbacks), 87 base::Bind(&OnGetDevicesComplete, base::Passed(&scoped_callbacks),
91 base::Unretained(device_services_.get()))); 88 base::Unretained(device_manager_.get())));
92 } 89 }
93 90
94 void WebUSBClientImpl::requestDevice( 91 void WebUSBClientImpl::requestDevice(
95 const blink::WebUSBDeviceRequestOptions& options, 92 const blink::WebUSBDeviceRequestOptions& options,
96 blink::WebUSBClientRequestDeviceCallbacks* callbacks) { 93 blink::WebUSBClientRequestDeviceCallbacks* callbacks) {
97 callbacks->onError(blink::WebUSBError(blink::WebUSBError::Error::Service, 94 callbacks->onError(blink::WebUSBError(blink::WebUSBError::Error::Service,
98 base::UTF8ToUTF16("Not implemented."))); 95 base::UTF8ToUTF16("Not implemented.")));
99 delete callbacks; 96 delete callbacks;
100 } 97 }
101 98
(...skipping 28 matching lines...) Expand all
130 const device::usb::DeviceInfoPtr& device_info = 127 const device::usb::DeviceInfoPtr& device_info =
131 notification->devices_removed[i]; 128 notification->devices_removed[i];
132 device::usb::DevicePtr device; 129 device::usb::DevicePtr device;
133 device_manager_->GetDevice(device_info->guid, mojo::GetProxy(&device)); 130 device_manager_->GetDevice(device_info->guid, mojo::GetProxy(&device));
134 observer_->onDeviceDisconnected(blink::adoptWebPtr(new WebUSBDeviceImpl( 131 observer_->onDeviceDisconnected(blink::adoptWebPtr(new WebUSBDeviceImpl(
135 device.Pass(), mojo::ConvertTo<blink::WebUSBDeviceInfo>(device_info)))); 132 device.Pass(), mojo::ConvertTo<blink::WebUSBDeviceInfo>(device_info))));
136 } 133 }
137 } 134 }
138 135
139 } // namespace content 136 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/usb/web_usb_client_impl.h ('k') | device/devices_app/devices_app.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698