Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1371793003: Improve plugin-attributes-enumeration test and rebaseline it (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve plugin-attributes-enumeration test and rebaseline it Previously the test depended on the placement of <object> and <embed> in the DOM. Putting them both in wrapper divs, and using a <div> instead of <body> to test for expected attributes, makes the test more targeted and as a bonus avoids depending on the output of 'typeof document.createElement("object")'. R=pdr@chromium.org BUG=527009 Committed: https://crrev.com/3d1bf8817452dfaf63b641e199a2da9baa0957ce Cr-Commit-Position: refs/heads/master@{#350957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/plugin-attributes-enumeration.html View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
adamk
5 years, 2 months ago (2015-09-25 23:25:08 UTC) #1
pdr.
lgtm
5 years, 2 months ago (2015-09-25 23:26:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371793003/1
5 years, 2 months ago (2015-09-25 23:27:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-26 00:16:37 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-26 00:17:38 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3d1bf8817452dfaf63b641e199a2da9baa0957ce
Cr-Commit-Position: refs/heads/master@{#350957}

Powered by Google App Engine
This is Rietveld 408576698