Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1371743003: Add missing dependency of sync_driver on policy_component. (Closed)

Created:
5 years, 2 months ago by byungchul
Modified:
5 years, 2 months ago
Reviewers:
stanisc, Nicolas Zea, pavely
CC:
chromium-reviews, halliwell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing dependency of sync_driver on policy_component. SyncPolicyHandler depends on policy::TypeCheckingPolicyHandler which is included in policy_component target. GYP missed the dependency while BUILD.gn has it correctly. BUG= Committed: https://crrev.com/ce5511be71acd80416e51da237e6e258b1579288 Cr-Commit-Position: refs/heads/master@{#351108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/sync_driver.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
byungchul
5 years, 2 months ago (2015-09-25 22:05:35 UTC) #2
pavely
lgtm
5 years, 2 months ago (2015-09-28 17:21:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371743003/1
5 years, 2 months ago (2015-09-28 18:17:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 19:26:14 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:27:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce5511be71acd80416e51da237e6e258b1579288
Cr-Commit-Position: refs/heads/master@{#351108}

Powered by Google App Engine
This is Rietveld 408576698