components/autofill/core/browser/autofill_manager.cc - Issue 1371713002: [Autofill] Return early when no new forms are parsed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 1371713002: [Autofill] Return early when no new forms are parsed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: initial Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_download_manager.cc ('K') | « components/autofill/core/browser/autofill_download_manager.cc ('k') | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 6c5948a41d01ec5936ac3119a9b09d7401e7d80a..df2adad38007dc6131edae6abc3a591f83bab740 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -1394,6 +1394,11 @@ std::vector<Suggestion> AutofillManager::GetCreditCardSuggestions(

}

void AutofillManager::ParseForms(const std::vector<FormData>& forms) {

+ if (forms.empty()) {

+ // The renderer doesn't have any forms to parse.

Evan Stade 2015/09/26 00:09:16 I don't think this comment adds much, the early re

Mathieu 2015/09/26 14:12:58 Done.

+ return;

+ }

std::vector<FormStructure*> non_queryable_forms;

for (const FormData& form : forms) {

scoped_ptr<FormStructure> form_structure(new FormStructure(form));