Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1371683002: media: GMBVideoFramePool, crop VideoFrame using visible_rect. (Closed)

Created:
5 years, 2 months ago by Daniele Castagna
Modified:
5 years, 2 months ago
Reviewers:
emircan, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: GMBVideoFramePool, crop VideoFrame using visible_rect. VideoFrame::visible_rect could be different than natural_size when the VideoFrame is coming from a media stream that is from a camera. crrev.com/1358883003 is planning to convert the video frames coming from different media sources. This CL crops VideoFrame using visible_rect when it gets converted to a new VideoFrame backed by GpuMemoryBuffers. BUG= Committed: https://crrev.com/ab977781fdcd23b3548202e9e422cd30edb67067 Cr-Commit-Position: refs/heads/master@{#351149}

Patch Set 1 #

Total comments: 2

Patch Set 2 : const size. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M media/video/gpu_memory_buffer_video_frame_pool.cc View 1 7 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Daniele Castagna
5 years, 2 months ago (2015-09-25 18:32:55 UTC) #2
emircan
lgtm. Thanks. https://codereview.chromium.org/1371683002/diff/1/media/video/gpu_memory_buffer_video_frame_pool.cc File media/video/gpu_memory_buffer_video_frame_pool.cc (right): https://codereview.chromium.org/1371683002/diff/1/media/video/gpu_memory_buffer_video_frame_pool.cc#newcode393 media/video/gpu_memory_buffer_video_frame_pool.cc:393: gfx::Size size = video_frame->visible_rect().size(); const
5 years, 2 months ago (2015-09-26 02:20:12 UTC) #3
Daniele Castagna
+dalecurtis for ownership. https://codereview.chromium.org/1371683002/diff/1/media/video/gpu_memory_buffer_video_frame_pool.cc File media/video/gpu_memory_buffer_video_frame_pool.cc (right): https://codereview.chromium.org/1371683002/diff/1/media/video/gpu_memory_buffer_video_frame_pool.cc#newcode393 media/video/gpu_memory_buffer_video_frame_pool.cc:393: gfx::Size size = video_frame->visible_rect().size(); On 2015/09/26 ...
5 years, 2 months ago (2015-09-28 15:46:57 UTC) #5
DaleCurtis
lgtm
5 years, 2 months ago (2015-09-28 20:56:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371683002/20001
5 years, 2 months ago (2015-09-28 20:58:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 21:08:01 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 21:11:20 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab977781fdcd23b3548202e9e422cd30edb67067
Cr-Commit-Position: refs/heads/master@{#351149}

Powered by Google App Engine
This is Rietveld 408576698