Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1371673004: Revert of JSObject::GetEnumProperty cleanup (Closed)

Created:
5 years, 2 months ago by vogelheim
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of JSObject::GetEnumProperty cleanup (patchset #2 id:20001 of https://codereview.chromium.org/1363293002/ ) Reason for revert: Reverting, because of broken GC stress bots. @cbruni: Sorry for the revert. I'm not entirely sure it's actually your CL; but policy is to revert speculatively if we can't determine an exact cause. Original issue's description: > JSObject::GetEnumProperty cleanup > > BUG= > > Committed: https://crrev.com/a00d47c802f93cf9835eafce4c9da2dd10b44f6a > Cr-Commit-Position: refs/heads/master@{#30946} TBR=jkummerow@chromium.org,cbruni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1213929ac3830e2fcf9ca72785d64f9e129b71e2 Cr-Commit-Position: refs/heads/master@{#30950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -104 lines) Patch
M src/field-index-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.cc View 3 chunks +95 lines, -101 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vogelheim
Created Revert of JSObject::GetEnumProperty cleanup
5 years, 2 months ago (2015-09-25 17:21:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371673004/1
5 years, 2 months ago (2015-09-25 17:21:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 17:22:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1213929ac3830e2fcf9ca72785d64f9e129b71e2 Cr-Commit-Position: refs/heads/master@{#30950}
5 years, 2 months ago (2015-09-25 17:22:29 UTC) #4
Michael Achenbach
5 years, 2 months ago (2015-09-25 20:27:37 UTC) #5
Message was sent while issue was closed.
All gc stress bots cycled green again after revert. Also auto-bisect pointed at
this CL, e.g.:
http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%202/build...

Powered by Google App Engine
This is Rietveld 408576698