Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1371673002: Remove a bunch of provisionalDataSource() usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | third_party/WebKit/Source/core/loader/EmptyClients.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index d6d5d6e1cf156cc581e8886e24df8e41e9870301..cfb29e5262c5b7576fad40af64b816c09516bd0d 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2860,25 +2860,21 @@ void RenderViewImpl::DidFlushPaint() {
if (main_frame->isWebRemoteFrame())
return;
- // If we have a provisional frame we are between the start and commit stages
- // of loading and we don't want to save stats.
- if (!main_frame->provisionalDataSource()) {
- WebDataSource* ds = main_frame->dataSource();
- if (!ds)
- return;
+ WebDataSource* ds = main_frame->dataSource();
+ if (!ds)
+ return;
- DocumentState* document_state = DocumentState::FromDataSource(ds);
+ DocumentState* document_state = DocumentState::FromDataSource(ds);
- // TODO(jar): The following code should all be inside a method, probably in
- // NavigatorState.
- Time now = Time::Now();
- if (document_state->first_paint_time().is_null()) {
- document_state->set_first_paint_time(now);
- }
- if (document_state->first_paint_after_load_time().is_null() &&
- !document_state->finish_load_time().is_null()) {
- document_state->set_first_paint_after_load_time(now);
- }
+ // TODO(jar): The following code should all be inside a method, probably in
+ // NavigatorState.
+ Time now = Time::Now();
+ if (document_state->first_paint_time().is_null()) {
+ document_state->set_first_paint_time(now);
+ }
+ if (document_state->first_paint_after_load_time().is_null() &&
+ !document_state->finish_load_time().is_null()) {
+ document_state->set_first_paint_after_load_time(now);
}
}
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | third_party/WebKit/Source/core/loader/EmptyClients.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698