Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: components/test_runner/web_test_proxy.cc

Issue 1371673002: Remove a bunch of provisionalDataSource() usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/web_test_proxy.h ('k') | content/public/renderer/render_frame_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_test_proxy.cc
diff --git a/components/test_runner/web_test_proxy.cc b/components/test_runner/web_test_proxy.cc
index 1dc3bf2d2fa24d8cac96d9f99ead835293bee3a7..9bc9c96ebf8047e43f5550fcb55ebcfcd849fd51 100644
--- a/components/test_runner/web_test_proxy.cc
+++ b/components/test_runner/web_test_proxy.cc
@@ -1084,7 +1084,7 @@ void WebTestProxyBase::DidReceiveServerRedirectForProvisionalLoad(
}
}
-bool WebTestProxyBase::DidFailProvisionalLoad(
+void WebTestProxyBase::DidFailProvisionalLoad(
blink::WebLocalFrame* frame,
const blink::WebURLError& error,
blink::WebHistoryCommitType commit_type) {
@@ -1093,7 +1093,6 @@ bool WebTestProxyBase::DidFailProvisionalLoad(
delegate_->PrintMessage(" - didFailProvisionalLoadWithError\n");
}
CheckDone(frame, MainResourceLoadFailed);
- return !frame->provisionalDataSource();
}
void WebTestProxyBase::DidCommitProvisionalLoad(
@@ -1176,7 +1175,6 @@ void WebTestProxyBase::DidDispatchPingLoader(blink::WebLocalFrame* frame,
}
void WebTestProxyBase::WillSendRequest(
- blink::WebLocalFrame* frame,
unsigned identifier,
blink::WebURLRequest& request,
const blink::WebURLResponse& redirect_response) {
« no previous file with comments | « components/test_runner/web_test_proxy.h ('k') | content/public/renderer/render_frame_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698