Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1371653002: Revert of "[heap] Add more tasks for parallel compaction" (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of "[heap] Add more tasks for parallel compaction" (patchset #4 id:100001 of https://codereview.chromium.org/1365743003/ ) Reason for revert: failing again: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Mac/builds/4505/steps/Mozilla%20%28flakes%29/logs/regress-416628 Original issue's description: > Reland of "[heap] Add more tasks for parallel compaction" > > - We now compute the number of parallel compaction tasks, depending on the > evacuation candidate list, the number of cores, and some hard limit. > - Free memory is moved over to compaction tasks (up to some limit) > - Moving over memory is done by dividing the free list of a given space up among > other free lists. Since this is potentially slow we limit the maximum amount > of moved memory. > > This reverts commit bfccd5187ceb21c99feea4538e08ca7aef48b65b. > > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/7e283d746a194ceaaca114e2ba17504653d6a109 > Cr-Commit-Position: refs/heads/master@{#30945} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/26f36f1092242bf350281db44bbcfe160ff1ca96 Cr-Commit-Position: refs/heads/master@{#30947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -210 lines) Patch
M src/heap/mark-compact.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 4 chunks +25 lines, -29 lines 0 comments Download
M src/heap/spaces.h View 11 chunks +25 lines, -95 lines 0 comments Download
M src/heap/spaces.cc View 4 chunks +20 lines, -80 lines 0 comments Download
M test/cctest/test-spaces.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Lippautz
Created Revert of "[heap] Add more tasks for parallel compaction"
5 years, 2 months ago (2015-09-25 15:40:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371653002/1
5 years, 2 months ago (2015-09-25 15:40:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 15:40:33 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 15:41:29 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26f36f1092242bf350281db44bbcfe160ff1ca96
Cr-Commit-Position: refs/heads/master@{#30947}

Powered by Google App Engine
This is Rietveld 408576698