Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1371593003: Set V8_FATAL and V8_UNIMPLEMENTED to ((void) 0) in Release (Closed)

Created:
5 years, 2 months ago by skomski
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Set V8_FATAL and V8_UNIMPLEMENTED to ((void) 0) in Release V8_UNREACHABLE is already defined as ((void) 0) and all three macros are already marked as unreliable in Release mode. For example in loops the code is not optimized by the clang vectorizer if a call to abort is possible. BUG=

Patch Set 1 #

Patch Set 2 : better formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/base/logging.h View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
Benedikt Meurer
Not sure if we want that. V8_FATAL and V8_UNIMPLEMENTED certainly help to track certain Chrome ...
5 years, 2 months ago (2015-09-25 08:41:49 UTC) #4
Jakob Kummerow
5 years, 2 months ago (2015-09-25 08:53:51 UTC) #5
Benedikt's guess is right, this does not lgtm. V8_FATAL in particular must crash
in Release mode.

If anything, we should consider making UNREACHABLE crash in Release mode too,
but I currently don't see any urgency to change anything.

If there are specific cases where we're missing out on important optimizations,
let's fix those places instead. (I'd be surprised if V8_UNIMPLEMENTED occurred
in hot loops.)

Powered by Google App Engine
This is Rietveld 408576698