Move password manager file names into components

Move password manager file names into components

This moves kAffiliationDatabaseFileName and kLoginDataFileName from //chrome to //components/password_manager, so that they can be used by the coming PasswordStoreFactory for iOS. It also puts the constants in browser code, as opposed to the previous common, because these constants cannot be used by the renderer code anyway (no filesystem access).

R=engedy@chromium.org

BUG=514183
Committed: https://crrev.com/20e857c3dd138c95ad24cb7ef99cc5ce99626651
Cr-Commit-Position: refs/heads/master@{#350796}

[vabr (Chromium), 2015-09-25 06:48:12]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-25 06:48:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1371593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1371593002/1

[commit-bot: I haz the power, 2015-09-25 07:03:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 07:03:20]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)

[vabr (Chromium), 2015-09-25 07:35:56]

vabr@chromium.org changed reviewers:
+ thestig@chromium.org

[vabr (Chromium), 2015-09-25 07:35:57]

Lei,
Please review chrome/common/chrome_constants.*.

Balázs,
Please review the whole CL.

Thanks!
Vaclav

https://codereview.chromium.org/1371593002/diff/1/chrome/common/chrome_consta...
File chrome/common/chrome_constants.cc (left):

https://codereview.chromium.org/1371593002/diff/1/chrome/common/chrome_consta...
chrome/common/chrome_constants.cc:7: #include "base/files/file_path.h"
This #include is already in the header, so removing it here while I'm at it.

[Lei Zhang, 2015-09-25 07:52:39]

lgtm

https://codereview.chromium.org/1371593002/diff/1/components/password_manager...
File components/password_manager/core/browser/password_manager_constants.cc
(right):

https://codereview.chromium.org/1371593002/diff/1/components/password_manager...
components/password_manager/core/browser/password_manager_constants.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
no (c), 2015

https://codereview.chromium.org/1371593002/diff/1/components/password_manager...
File components/password_manager/core/browser/password_manager_constants.h
(right):

https://codereview.chromium.org/1371593002/diff/1/components/password_manager...
components/password_manager/core/browser/password_manager_constants.h:1: //
Copyright (c) 2015 The Chromium Authors. All rights reserved.
no (c)

[engedy, 2015-09-25 08:11:54]

LGTM.

[vabr (Chromium), 2015-09-25 08:30:47]

Thanks!

Comments addressed, sending to CQ.

Vaclav

https://codereview.chromium.org/1371593002/diff/1/components/password_manager...
File components/password_manager/core/browser/password_manager_constants.cc
(right):

https://codereview.chromium.org/1371593002/diff/1/components/password_manager...
components/password_manager/core/browser/password_manager_constants.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
On 2015/09/25 07:52:38, Lei Zhang wrote:
> no (c), 2015

Done.

https://codereview.chromium.org/1371593002/diff/1/components/password_manager...
File components/password_manager/core/browser/password_manager_constants.h
(right):

https://codereview.chromium.org/1371593002/diff/1/components/password_manager...
components/password_manager/core/browser/password_manager_constants.h:1: //
Copyright (c) 2015 The Chromium Authors. All rights reserved.
On 2015/09/25 07:52:38, Lei Zhang wrote:
> no (c)

Done.

[vabr (Chromium), 2015-09-25 08:30:52]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2015-09-25 08:30:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, engedy@chromium.org
Link to the patchset: https://codereview.chromium.org/1371593002/#ps20001
(title: "Fixed copyrights")

[commit-bot: I haz the power, 2015-09-25 08:31:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1371593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1371593002/20001

[commit-bot: I haz the power, 2015-09-25 09:34:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-25 09:35:10]

Patchset 2 (id:??) landed as
https://crrev.com/20e857c3dd138c95ad24cb7ef99cc5ce99626651
Cr-Commit-Position: refs/heads/master@{#350796}