Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/dom/src/Validators.dart

Issue 1371543002: Make sure we short-circuit the second corruption test, it might be crashing firefox (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/src/Validators.dart
diff --git a/tools/dom/src/Validators.dart b/tools/dom/src/Validators.dart
index d964153afea1d46ce71e489f3bd4773977f9dc05..4dbe32c5942269275d38bf590e5d6a5cf60e1c0f 100644
--- a/tools/dom/src/Validators.dart
+++ b/tools/dom/src/Validators.dart
@@ -214,8 +214,7 @@ class _ValidatingTreeSanitizer implements NodeTreeSanitizer {
// On IE, erratically, the hasCorruptedAttributes test can return false,
// even though it clearly is corrupted. A separate copy of the test
// inlining just the basic check seems to help.
- var corruptedTest2 = Element._hasCorruptedAttributesAdditionalCheck(element);
- corrupted = corruptedTest1 || corruptedTest2;
+ corrupted = corruptedTest1 ? true : Element._hasCorruptedAttributesAdditionalCheck(element);
} catch(e) {}
var elementText = 'element unprintable';
try {
« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698