Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: third_party/WebKit/public/web/WebPageSerializer.h

Issue 1371533002: Remove "recursive" parameter from WebPageSerializer::serialize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-complete-serialization
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebPageSerializer.h
diff --git a/third_party/WebKit/public/web/WebPageSerializer.h b/third_party/WebKit/public/web/WebPageSerializer.h
index 333e010eb44f82ca52d41b088c2c20b9690bc3eb..f1a5f372e9db69993996ae406a565e17d5dce753 100644
--- a/third_party/WebKit/public/web/WebPageSerializer.h
+++ b/third_party/WebKit/public/web/WebPageSerializer.h
@@ -70,17 +70,14 @@ public:
// The API below is an older implementation of a pageserialization that
// will be removed soon.
-
- // This function will find out all frames and serialize them to HTML data.
+ // This function will serialize the specified frame to HTML data.
// We have a data buffer to temporary saving generated html data. We will
// sequentially call WebPageSeriazlierClient once the data buffer is full.
//
- // Return false means no available frame has been serialized, otherwise
- // return true.
+ // Return false means if no data has been serialized (i.e. because
+ // the target frame didn't have a valid url).
//
// The parameter frame specifies which frame need to be serialized.
- // The parameter recursive specifies whether we need to
- // serialize all sub frames of the specified frame or not.
// The parameter client specifies the pointer of interface
// WebPageSerializerClient providing a sink interface to receive the
// individual chunks of data to be saved.
@@ -91,7 +88,6 @@ public:
// contain all saved auxiliary files included all sub frames and resources.
BLINK_EXPORT static bool serialize(
WebLocalFrame*,
- bool recursive,
WebPageSerializerClient*,
const WebVector<WebURL>& links,
const WebVector<WebString>& localPaths,

Powered by Google App Engine
This is Rietveld 408576698