Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Side by Side Diff: base/OWNERS

Issue 1371513003: Base: Remove myself from owners (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moar Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/files/OWNERS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 mark@chromium.org 1 mark@chromium.org
2 thakis@chromium.org 2 thakis@chromium.org
3 danakj@chromium.org 3 danakj@chromium.org
4 rvargas@chromium.org
5 thestig@chromium.org 4 thestig@chromium.org
6 5
7 # Chromium is a very mature project, most things that are generally useful are 6 # Chromium is a very mature project, most things that are generally useful are
8 # already here, and that things not here aren't generally useful. 7 # already here, and that things not here aren't generally useful.
9 # 8 #
10 # Base is pulled into many projects. For example, various ChromeOS daemons. So 9 # Base is pulled into many projects. For example, various ChromeOS daemons. So
11 # the bar for adding stuff is that it must have demonstrated wide 10 # the bar for adding stuff is that it must have demonstrated wide
12 # applicability. Prefer to add things closer to where they're used (i.e. "not 11 # applicability. Prefer to add things closer to where they're used (i.e. "not
13 # base"), and pull into base only when needed. In a project our size, 12 # base"), and pull into base only when needed. In a project our size,
14 # sometimes even duplication is OK and inevitable. 13 # sometimes even duplication is OK and inevitable.
15 # 14 #
16 # Adding a new logging macro DPVELOG_NE is not more clear than just 15 # Adding a new logging macro DPVELOG_NE is not more clear than just
17 # writing the stuff you want to log in a regular logging statement, even 16 # writing the stuff you want to log in a regular logging statement, even
18 # if it makes your calling code longer. Just add it to your own code. 17 # if it makes your calling code longer. Just add it to your own code.
19 18
20 per-file *.isolate=maruel@chromium.org 19 per-file *.isolate=maruel@chromium.org
21 per-file *.isolate=tandrii@chromium.org 20 per-file *.isolate=tandrii@chromium.org
22 per-file *.isolate=vadimsh@chromium.org 21 per-file *.isolate=vadimsh@chromium.org
23 per-file security_unittest.cc=jln@chromium.org 22 per-file security_unittest.cc=jln@chromium.org
24 23
25 # For Android-specific changes: 24 # For Android-specific changes:
26 per-file *android*=nyquist@chromium.org 25 per-file *android*=nyquist@chromium.org
27 per-file *android*=rmcilroy@chromium.org 26 per-file *android*=rmcilroy@chromium.org
28 per-file *android*=yfriedman@chromium.org 27 per-file *android*=yfriedman@chromium.org
29 28
30 # For FeatureList API: 29 # For FeatureList API:
31 per-file feature_list*=asvitkine@chromium.org 30 per-file feature_list*=asvitkine@chromium.org
32 per-file feature_list*=isherman@chromium.org 31 per-file feature_list*=isherman@chromium.org
OLDNEW
« no previous file with comments | « no previous file | base/files/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698