Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1371463003: Move PathService to the base namespace. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
yzshen1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PathService to the base namespace. This leaves a "using" statement in to allow landing without updating all callers atomically. Committed: https://crrev.com/f0dea131164e6d7a23ff0610dc73bba81a3eefee Cr-Commit-Position: refs/heads/master@{#350896}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -106 lines) Patch
M base/path_service.h View 7 chunks +11 lines, -6 lines 0 comments Download
M base/path_service.cc View 1 2 15 chunks +40 lines, -41 lines 0 comments Download
M base/path_service_unittest.cc View 11 chunks +62 lines, -59 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
brettw
Low priority
5 years, 3 months ago (2015-09-24 23:12:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371463003/20001
5 years, 3 months ago (2015-09-24 23:14:31 UTC) #4
yzshen1
LGTM https://codereview.chromium.org/1371463003/diff/20001/base/path_service.cc File base/path_service.cc (right): https://codereview.chromium.org/1371463003/diff/20001/base/path_service.cc#newcode24 base/path_service.cc:24: bool PathProviderWin(int key, FilePath* result); I think we ...
5 years, 3 months ago (2015-09-24 23:19:02 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-25 00:35:18 UTC) #7
brettw
https://codereview.chromium.org/1371463003/diff/20001/base/path_service.cc File base/path_service.cc (right): https://codereview.chromium.org/1371463003/diff/20001/base/path_service.cc#newcode24 base/path_service.cc:24: bool PathProviderWin(int key, FilePath* result); On 2015/09/24 23:19:02, yzshen1 ...
5 years, 2 months ago (2015-09-25 17:23:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371463003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371463003/40001
5 years, 2 months ago (2015-09-25 17:24:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/67581)
5 years, 2 months ago (2015-09-25 18:16:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371463003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371463003/40001
5 years, 2 months ago (2015-09-25 19:37:19 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-25 20:09:05 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 20:10:06 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f0dea131164e6d7a23ff0610dc73bba81a3eefee
Cr-Commit-Position: refs/heads/master@{#350896}

Powered by Google App Engine
This is Rietveld 408576698