tools/telemetry/telemetry/core/platform/android_platform_backend.py - Issue 137143011: [Telemetry] Detect whether sudo is required for certain admin-commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/android_platform_backend.py

Issue 137143011: [Telemetry] Detect whether sudo is required for certain admin-commands. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reupload Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/__init__.py ('k') | tools/telemetry/telemetry/core/platform/mac_platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/android_platform_backend.py

diff --git a/tools/telemetry/telemetry/core/platform/android_platform_backend.py b/tools/telemetry/telemetry/core/platform/android_platform_backend.py

index 64c8f645c1a32d5ddc20604bf48c99d5dc9d8440..28b2ee395685b03a8fa2ea1461b847ac5df68df6 100644

--- a/tools/telemetry/telemetry/core/platform/android_platform_backend.py

+++ b/tools/telemetry/telemetry/core/platform/android_platform_backend.py

@@ -167,10 +167,14 @@ class AndroidPlatformBackend(

def FlushSystemCacheForDirectory(self, directory, ignoring=None):

raise NotImplementedError()

- def LaunchApplication(self, application, parameters=None):

+ def LaunchApplication(

+ self, application, parameters=None, elevate_privilege=False):

if application in _HOST_APPLICATIONS:

- self._host_platform_backend.LaunchApplication(application, parameters)

+ self._host_platform_backend.LaunchApplication(

+ application, parameters, elevate_privilege=elevate_privilege)

return

+ if elevate_privilege:

+ raise NotImplementedError("elevate_privilege isn't supported on android.")

if not parameters:

parameters = ''

self._adb.RunShellCommand('am start ' + parameters + ' ' + application)