Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 137143005: Removes the rotation and scaling in SnapshotAura. (Closed)

Created:
6 years, 11 months ago by Jun Mukai
Modified:
6 years, 11 months ago
Reviewers:
enne (OOO), sky, piman
CC:
chromium-reviews, Sergey Ulanov
Visibility:
Public.

Description

Removes the rotation and scaling in SnapshotAura. It seems that the compositor already takes care of the screen rotation and scaling. SnapshotAura doesn't need to do that. Also, snapshot_aura_unittest.cc is not good for rotation and scaling because the existing test just paint plain red. This CL changes the paint content to fail if the rotation is not handled correctly. BUG=337559 R=piman@chromium.org, enne@chromium.org, sky@chromium.org TEST=manually && snapshot_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246802

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -117 lines) Patch
M ui/snapshot/snapshot_aura.cc View 1 2 6 chunks +17 lines, -102 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 9 chunks +26 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Mukai
6 years, 11 months ago (2014-01-23 23:04:08 UTC) #1
enne (OOO)
+sergeyu for changes to GrabWindowSnapshotAndScaleAsync
6 years, 11 months ago (2014-01-23 23:08:47 UTC) #2
piman
lgtm
6 years, 11 months ago (2014-01-23 23:40:28 UTC) #3
Jun Mukai
sky, could you take a look?
6 years, 11 months ago (2014-01-23 23:46:42 UTC) #4
sky
LGTM https://codereview.chromium.org/137143005/diff/30001/ui/snapshot/snapshot_aura.cc File ui/snapshot/snapshot_aura.cc (right): https://codereview.chromium.org/137143005/diff/30001/ui/snapshot/snapshot_aura.cc#newcode44 ui/snapshot/snapshot_aura.cc:44: gfx::Size target_size) { const gfx::Size&
6 years, 11 months ago (2014-01-24 00:44:42 UTC) #5
Jun Mukai
https://codereview.chromium.org/137143005/diff/30001/ui/snapshot/snapshot_aura.cc File ui/snapshot/snapshot_aura.cc (right): https://codereview.chromium.org/137143005/diff/30001/ui/snapshot/snapshot_aura.cc#newcode44 ui/snapshot/snapshot_aura.cc:44: gfx::Size target_size) { On 2014/01/24 00:44:43, sky wrote: > ...
6 years, 11 months ago (2014-01-24 01:16:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/137143005/30002
6 years, 11 months ago (2014-01-24 01:18:44 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 07:26:19 UTC) #8
Message was sent while issue was closed.
Change committed as 246802

Powered by Google App Engine
This is Rietveld 408576698