mojo/nacl/nexe_launcher_nonsfi.h - Issue 1371413003: Refactored launching of nexes to separate file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/nacl/nexe_launcher_nonsfi.h

Issue 1371413003: Refactored launching of nexes to separate file. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Code Review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MOJO_NACL_NEXE_LAUNCHER_NONSFI_H_

	6 #define MOJO_NACL_NEXE_LAUNCHER_NONSFI_H_

	7

	8 #include "mojo/public/c/system/types.h"

	9 #include "native_client/src/public/irt_core.h"
	Mark Seaborn 2015/10/02 22:31:57 Nit: These two NaCl headers aren't needed by this Nit: These two NaCl headers aren't needed by this .h file. Sean Klein 2015/10/02 22:41:10 Done. Show quoted text On 2015/10/02 22:31:57, Mark Seaborn wrote: > Nit: These two NaCl headers aren't needed by this .h file. Done.
	10 #include "native_client/src/public/nonsfi/elf_loader.h"

	11

	12 namespace nacl {

	13

	14 /**

	15 * Takes a fd to a nexe, and launches the nexe with the given

	16 * MojoHandle.

	17 */

	18 void MojoLaunchNexeNonsfi(int fd, MojoHandle handle);
	Mark Seaborn 2015/10/02 22:31:57 Suggestion: Could make this more self-documenting Suggestion: Could make this more self-documenting by naming the args "nexe_fd" and "initial_handle". Sean Klein 2015/10/02 22:41:10 Done. Show quoted text On 2015/10/02 22:31:57, Mark Seaborn wrote: > Suggestion: Could make this more self-documenting by naming the args "nexe_fd" > and "initial_handle". Done.
	19

	20 } // namespace nacl

	21

	22 #endif // MOJO_NACL_NEXE_LAUNCHER_NONSFI_H_

OLD	NEW