mojo/nacl/nexe_launcher_nonsfi.h - Issue 1371413003: Refactored launching of nexes to separate file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/nacl/nexe_launcher_nonsfi.h

Issue 1371413003: Refactored launching of nexes to separate file. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MOJO_NACL_NEXE_LAUNCHER_NONSFI_H_

	6 #define MOJO_NACL_NEXE_LAUNCHER_NONSFI_H_

	7

	8 #include "mojo/public/c/system/types.h"

	9 #include "native_client/src/public/irt_core.h"

	10 #include "native_client/src/public/nonsfi/elf_loader.h"

	11

	12 /**

	13 * Takes a fd to a nexe, and launches the nexe with the given

	14 * MojoHandle.

	15 */

	16 void launch_nexe_nonsfi(int fd, MojoHandle handle);
	Petr Hosek 2015/10/01 23:03:57 Since this is C++, shouldn't this live in nacl nam Since this is C++, shouldn't this live in nacl namespace? We should also follow Mojo convetions so this function should probably be named as MojoLaunchNexeNonsfi (or something along those lines). Sean Klein 2015/10/01 23:24:05 Done. Show quoted text On 2015/10/01 23:03:57, Petr Hosek wrote: > Since this is C++, shouldn't this live in nacl namespace? We should also follow > Mojo convetions so this function should probably be named as > MojoLaunchNexeNonsfi (or something along those lines). Done.
	17

	18 #endif // MOJO_NACL_NEXE_LAUNCHER_NONSFI_H_
	Petr Hosek 2015/10/01 23:03:57 Two spaces between `endif` and `//` (it's weird bu Two spaces between `endif` and `//` (it's weird but that's what Google/Chromium code style says). Sean Klein 2015/10/01 23:24:05 Done. Show quoted text On 2015/10/01 23:03:57, Petr Hosek wrote: > Two spaces between `endif` and `//` (it's weird but that's what Google/Chromium > code style says). Done.
OLD	NEW

« no previous file with comments | « mojo/nacl/BUILD.gn ('k') | mojo/nacl/nexe_launcher_nonsfi.cc » ('j') | no next file with comments »