tools/telemetry/PRESUBMIT.py - Issue 1371403004: CL for perf tryjob on mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/PRESUBMIT.py

Issue 1371403004: CL for perf tryjob on mac Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/run-perf-test.cfg ('k') | tools/telemetry/telemetry/__init__.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2012 The Chromium Authors. All rights reserved.	1 # Copyright 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5	5

6 def _CommonChecks(input_api, output_api):	6 def _CommonChecks(input_api, output_api):

7 results = []	7 results = []

8	8

9 # TODO(nduca): This should call update_docs.IsUpdateDocsNeeded().	9 # TODO(nduca): This should call update_docs.IsUpdateDocsNeeded().

10 # Disabled due to crbug.com/255326.	10 # Disabled due to crbug.com/255326.

(...skipping 59 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70 input_api.os_path.join(telemetry_dir, 'third_party', 'pexpect'),	70 input_api.os_path.join(telemetry_dir, 'third_party', 'pexpect'),

71 input_api.os_path.join(telemetry_dir, 'third_party', 'png'),	71 input_api.os_path.join(telemetry_dir, 'third_party', 'png'),

72 input_api.os_path.join(telemetry_dir, 'third_party', 'pyserial'),	72 input_api.os_path.join(telemetry_dir, 'third_party', 'pyserial'),

73 input_api.os_path.join(telemetry_dir, 'third_party', 'typ'),	73 input_api.os_path.join(telemetry_dir, 'third_party', 'typ'),

74 input_api.os_path.join(telemetry_dir, 'third_party', 'webpagereplay'),	74 input_api.os_path.join(telemetry_dir, 'third_party', 'webpagereplay'),

75 input_api.os_path.join(telemetry_dir, 'third_party', 'websocket-client'),	75 input_api.os_path.join(telemetry_dir, 'third_party', 'websocket-client'),

76	76

77 input_api.os_path.join(chromium_src_dir, 'build', 'android'),	77 input_api.os_path.join(chromium_src_dir, 'build', 'android'),

78 input_api.os_path.join(chromium_src_dir,	78 input_api.os_path.join(chromium_src_dir,

79 'third_party', 'catapult', 'tracing'),	79 'third_party', 'catapult', 'tracing'),

	80 input_api.os_path.join(chromium_src_dir,

	81 'third_party', 'catapult', 'perf_insights'),

80 ]	82 ]

81	83

82	84

83 def CheckChangeOnUpload(input_api, output_api):	85 def CheckChangeOnUpload(input_api, output_api):

84 results = []	86 results = []

85 results.extend(_CommonChecks(input_api, output_api))	87 results.extend(_CommonChecks(input_api, output_api))

86 return results	88 return results

87	89

88	90

89 def CheckChangeOnCommit(input_api, output_api):	91 def CheckChangeOnCommit(input_api, output_api):

90 results = []	92 results = []

91 results.extend(_CommonChecks(input_api, output_api))	93 results.extend(_CommonChecks(input_api, output_api))

92 return results	94 return results

OLD	NEW