Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1371393003: [Fetch] Support blob: scheme (Closed)

Created:
5 years, 2 months ago by hiroshige
Modified:
5 years, 1 month ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Fetch] Support blob: scheme Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/uajNnbH8UPU BUG=521466 Committed: https://crrev.com/1b0d116ada024cae994f17cf694f84b5d54ee357 Cr-Commit-Position: refs/heads/master@{#357054}

Patch Set 1 #

Patch Set 2 : Comment fix. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -16 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/scheme-blob.js View 1 chunk +32 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/scheme-blob.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/scheme-blob-base-https-other-https.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/scheme-blob-other-https.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/thorough/scheme-blob.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/thorough/scheme-blob-base-https-other-https.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/thorough/scheme-blob-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/window/thorough/scheme-blob.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/window/thorough/scheme-blob-base-https-other-https.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/window/thorough/scheme-blob-other-https.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/workers/thorough/scheme-blob.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/workers/thorough/scheme-blob-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/fetch/workers/thorough/scheme-blob-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 2 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371393003/1
5 years, 2 months ago (2015-09-30 09:07:19 UTC) #2
hiroshige
Migrated from https://codereview.chromium.org/1336933003/.
5 years, 2 months ago (2015-09-30 09:10:13 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371393003/20001
5 years, 2 months ago (2015-09-30 09:10:22 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 13:27:53 UTC) #7
hiroshige
Migrated from https://codereview.chromium.org/1336933003/. PTAL.
5 years, 2 months ago (2015-09-30 13:33:01 UTC) #9
yhirano
lgtm
5 years, 2 months ago (2015-10-06 05:04:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371393003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371393003/40001
5 years, 1 month ago (2015-10-30 06:20:16 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-30 08:20:59 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 08:22:41 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1b0d116ada024cae994f17cf694f84b5d54ee357
Cr-Commit-Position: refs/heads/master@{#357054}

Powered by Google App Engine
This is Rietveld 408576698