Continuing removing deprecated function from cctest

Continuing removing deprecated function from cctest

Removes deprecated functions from the following files:

test/cctest/test-object-observe.cc
test/cctest/test-parsing.cc
test/cctest/test-platform.cc
test/cctest/test-platform-linux.cc
test/cctest/test-platform-win32.cc
test/cctest/test-profile-generator.cc
test/cctest/test-random-number-generator.cc
test/cctest/test-regexp.cc
test/cctest/test-reloc-info.cc
test/cctest/test-representation.cc
test/cctest/test-sampler-api.cc
test/cctest/test-serialize.cc
test/cctest/test-simd.cc
test/cctest/test-slots-buffer.cc
test/cctest/test-spaces.cc
test/cctest/test-strings.cc
test/cctest/test-strtod.cc
test/cctest/test-symbols.cc
test/cctest/test-threads.cc

BUG=v8:4134
LOG=n

Committed: https://crrev.com/6105581e40c0bea45d48cd9af6b89c19e257a0f5
Cr-Commit-Position: refs/heads/master@{#31173}

[mythria, 2015-10-02 10:15:12]

mythria@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[mythria, 2015-10-02 10:15:12]

Hi,

Could you please review my changes.

Thanks and Regards,
Mythri

[rmcilroy, 2015-10-06 10:53:57]

lgtm with a couple of nits, thanks!

https://codereview.chromium.org/1371363006/diff/1/test/cctest/test-object-obs...
File test/cctest/test-object-observe.cc (right):

https://codereview.chromium.org/1371363006/diff/1/test/cctest/test-object-obs...
test/cctest/test-object-observe.cc:38: inline int32_t
ToInt32_t(v8::Local<v8::Value> value) {
nit - just ToInt32 (drop the "_t")

https://codereview.chromium.org/1371363006/diff/1/test/cctest/test-object-obs...
test/cctest/test-object-observe.cc:370: // ForceSet should work just as well as
Set
Update comment

[mythria, 2015-10-06 11:12:23]

fixed both of them.

Thanks and Regards,
Mythri

https://codereview.chromium.org/1371363006/diff/1/test/cctest/test-object-obs...
File test/cctest/test-object-observe.cc (right):

https://codereview.chromium.org/1371363006/diff/1/test/cctest/test-object-obs...
test/cctest/test-object-observe.cc:38: inline int32_t
ToInt32_t(v8::Local<v8::Value> value) {
On 2015/10/06 10:53:57, rmcilroy wrote:
> nit - just ToInt32 (drop the "_t")

Done.

https://codereview.chromium.org/1371363006/diff/1/test/cctest/test-object-obs...
test/cctest/test-object-observe.cc:370: // ForceSet should work just as well as
Set
On 2015/10/06 10:53:57, rmcilroy wrote:
> Update comment

Done.

[mythria, 2015-10-06 16:30:29]

Fixed a bug in test-serialize.cc. I used isolate1 instead of isolate2. isolate1
was already disposed, so test crashed on 4 platforms. I am surprised it passed
on all others.

[mythria, 2015-10-08 09:26:03]

The CQ bit was checked by mythria@chromium.org

[mythria, 2015-10-08 09:26:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1371363006/#ps60001
(title: "Fixed a bug in test-serialize.cc.")

[commit-bot: I haz the power, 2015-10-08 09:26:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1371363006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1371363006/60001

[commit-bot: I haz the power, 2015-10-08 09:48:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-08 09:48:31]

Patchset 4 (id:??) landed as
https://crrev.com/6105581e40c0bea45d48cd9af6b89c19e257a0f5
Cr-Commit-Position: refs/heads/master@{#31173}