Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/parser.h

Issue 1371333004: [es6] Scoping & initialization for var shadowing non-simple parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PARSER_H_ 5 #ifndef V8_PARSER_H_
6 #define V8_PARSER_H_ 6 #define V8_PARSER_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/ast.h" 9 #include "src/ast.h"
10 #include "src/compiler.h" // TODO(titzer): remove this include dependency 10 #include "src/compiler.h" // TODO(titzer): remove this include dependency
(...skipping 1105 matching lines...) Expand 10 before | Expand all | Expand 10 after
1116 Scanner::Location class_name_location, 1116 Scanner::Location class_name_location,
1117 bool name_is_strict_reserved, int pos, 1117 bool name_is_strict_reserved, int pos,
1118 bool* ok); 1118 bool* ok);
1119 1119
1120 // Magical syntax support. 1120 // Magical syntax support.
1121 Expression* ParseV8Intrinsic(bool* ok); 1121 Expression* ParseV8Intrinsic(bool* ok);
1122 1122
1123 // Get odd-ball literals. 1123 // Get odd-ball literals.
1124 Literal* GetLiteralUndefined(int position); 1124 Literal* GetLiteralUndefined(int position);
1125 1125
1126 // For harmony block scoping mode: Check if the scope has conflicting var/let 1126 // Check if the scope has conflicting var/let declarations from different
1127 // declarations from different scopes. It covers for example 1127 // scopes. This covers for example
1128 // 1128 //
1129 // function f() { { { var x; } let x; } } 1129 // function f() { { { var x; } let x; } }
1130 // function g() { { var x; let x; } } 1130 // function g() { { var x; let x; } }
1131 // 1131 //
1132 // The var declarations are hoisted to the function scope, but originate from 1132 // The var declarations are hoisted to the function scope, but originate from
1133 // a scope where the name has also been let bound or the var declaration is 1133 // a scope where the name has also been let bound or the var declaration is
1134 // hoisted over such a scope. 1134 // hoisted over such a scope.
1135 void CheckConflictingVarDeclarations(Scope* scope, bool* ok); 1135 void CheckConflictingVarDeclarations(Scope* scope, bool* ok);
1136 1136
1137 // Insert initializer statements for var-bindings shadowing parameter bindings
1138 // from a non-simple parameter list.
1139 void InsertShadowingVarBindingInitializers(Block* block);
1140
1137 // Implement sloppy block-scoped functions, ES2015 Annex B 3.3 1141 // Implement sloppy block-scoped functions, ES2015 Annex B 3.3
1138 void InsertSloppyBlockFunctionVarBindings(Scope* scope, bool* ok); 1142 void InsertSloppyBlockFunctionVarBindings(Scope* scope, bool* ok);
1139 1143
1140 // Parser support 1144 // Parser support
1141 VariableProxy* NewUnresolved(const AstRawString* name, VariableMode mode); 1145 VariableProxy* NewUnresolved(const AstRawString* name, VariableMode mode);
1142 Variable* Declare(Declaration* declaration, 1146 Variable* Declare(Declaration* declaration,
1143 DeclarationDescriptor::Kind declaration_kind, bool resolve, 1147 DeclarationDescriptor::Kind declaration_kind, bool resolve,
1144 bool* ok, Scope* declaration_scope = nullptr); 1148 bool* ok, Scope* declaration_scope = nullptr);
1145 1149
1146 bool TargetStackContainsLabel(const AstRawString* label); 1150 bool TargetStackContainsLabel(const AstRawString* label);
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
1369 parser_->BuildParameterInitializationBlock(parameters, ok); 1373 parser_->BuildParameterInitializationBlock(parameters, ok);
1370 if (!*ok) return; 1374 if (!*ok) return;
1371 if (init_block != nullptr) { 1375 if (init_block != nullptr) {
1372 body->Add(init_block, parser_->zone()); 1376 body->Add(init_block, parser_->zone());
1373 } 1377 }
1374 } 1378 }
1375 } 1379 }
1376 } } // namespace v8::internal 1380 } } // namespace v8::internal
1377 1381
1378 #endif // V8_PARSER_H_ 1382 #endif // V8_PARSER_H_
OLDNEW
« no previous file with comments | « no previous file | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698