Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 137133002: Make all the files mapped in when running browser_tests read only. (Closed)

Created:
6 years, 11 months ago by M-A Ruel
Modified:
6 years, 10 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews
Visibility:
Public.

Description

Make all the files mapped in when running browser_tests read only. This means no file can be opened for write during the test run. R=vadimsh@chromium.org NOTRY=true BUG=116251 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251074

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser_tests.isolate View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
M-A Ruel
... and browser_tests.
6 years, 11 months ago (2014-01-15 19:03:53 UTC) #1
Vadim Sh.
lgtm, but lets land them one at a time.
6 years, 11 months ago (2014-01-15 19:05:54 UTC) #2
M-A Ruel
On 2014/01/15 19:05:54, Vadim Sh. wrote: > lgtm, but lets land them one at a ...
6 years, 11 months ago (2014-01-15 19:06:44 UTC) #3
M-A Ruel
The CQ bit was checked by maruel@chromium.org
6 years, 10 months ago (2014-02-06 23:54:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/137133002/1
6 years, 10 months ago (2014-02-06 23:55:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 01:23:20 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=259328
6 years, 10 months ago (2014-02-07 01:23:21 UTC) #7
M-A Ruel
The CQ bit was checked by maruel@chromium.org
6 years, 10 months ago (2014-02-07 18:38:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/137133002/1
6 years, 10 months ago (2014-02-07 18:40:29 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 20:04:03 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=260005
6 years, 10 months ago (2014-02-07 20:04:04 UTC) #11
M-A Ruel
Ok, so I rebased to be sure and ran: git cl try -b linux_rel:browser_tests -b ...
6 years, 10 months ago (2014-02-13 17:34:54 UTC) #12
M-A Ruel
The CQ bit was checked by maruel@chromium.org
6 years, 10 months ago (2014-02-13 17:35:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/137133002/550001
6 years, 10 months ago (2014-02-13 17:35:13 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 17:39:42 UTC) #15
Message was sent while issue was closed.
Change committed as 251074

Powered by Google App Engine
This is Rietveld 408576698