Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1371303003: Unify ThreadID. (Closed)

Created:
5 years, 2 months ago by herb_g
Modified:
5 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : use kIllegalThreadID #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -41 lines) Patch
M gyp/core.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M include/private/SkMutex.h View 1 5 chunks +10 lines, -21 lines 0 comments Download
A include/private/SkThreadID.h View 1 1 chunk +19 lines, -0 lines 1 comment Download
M src/core/SkSharedMutex.cpp View 10 chunks +12 lines, -20 lines 0 comments Download
A src/core/SkThreadID.cpp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371303003/1
5 years, 2 months ago (2015-09-29 19:49:34 UTC) #2
herb_g
5 years, 2 months ago (2015-09-29 19:49:59 UTC) #4
mtklein
https://codereview.chromium.org/1371303003/diff/1/include/private/SkMutex.h File include/private/SkMutex.h (right): https://codereview.chromium.org/1371303003/diff/1/include/private/SkMutex.h#newcode35 include/private/SkMutex.h:35: static const SkThreadID kNoOwner = 0; Think it makes ...
5 years, 2 months ago (2015-09-29 19:52:40 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-29 19:56:26 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371303003/20001
5 years, 2 months ago (2015-09-29 20:23:18 UTC) #10
herb_g
https://codereview.chromium.org/1371303003/diff/1/include/private/SkMutex.h File include/private/SkMutex.h (right): https://codereview.chromium.org/1371303003/diff/1/include/private/SkMutex.h#newcode35 include/private/SkMutex.h:35: static const SkThreadID kNoOwner = 0; On 2015/09/29 19:52:40, ...
5 years, 2 months ago (2015-09-29 20:25:02 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-29 20:30:18 UTC) #13
mtklein
https://codereview.chromium.org/1371303003/diff/20001/include/private/SkThreadID.h File include/private/SkThreadID.h (right): https://codereview.chromium.org/1371303003/diff/20001/include/private/SkThreadID.h#newcode17 include/private/SkThreadID.h:17: const SkThreadID kIllegalThreadID = 0; static? or ODR silently ...
5 years, 2 months ago (2015-09-29 20:48:26 UTC) #14
mtklein
TIL, lgtm
5 years, 2 months ago (2015-09-29 21:34:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371303003/20001
5 years, 2 months ago (2015-09-29 21:37:26 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 21:38:06 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e4c17356b6c819df8effb29dfb4bb903520b8c2b

Powered by Google App Engine
This is Rietveld 408576698