src/parser.cc - Issue 1371263003: Prohibit let in lexical bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 1371263003: Prohibit let in lexical bindings (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove messages.js test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index f122d9aa5e4b57ff1459cfa48e060c666bd407ff..d3c607f5bce29ef037db653ccaeb52d2a862be17 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -2535,6 +2535,10 @@ void Parser::ParseVariableDeclarations(VariableDeclarationContext var_context,

if (!*ok) return;

ValidateBindingPattern(&pattern_classifier, ok);

if (!*ok) return;

+ if (IsLexicalVariableMode(parsing_result->descriptor.mode)) {

+ ValidateLetPattern(&pattern_classifier, ok);

+ if (!*ok) return;

+ }

if (!allow_harmony_destructuring() && !pattern->IsVariableProxy()) {

ReportUnexpectedToken(next);

*ok = false;

« no previous file with comments | « src/messages.h ('k') | src/preparser.h » ('j') | no next file with comments »