|
|
DescriptionTell MSAN that profiler doesn't expect sp to point at initialized memory
BUG=v8:4444, v8:4151
LOG=N
Committed: https://crrev.com/4fd8c327de7759aa987869a8933ef5a09a670b34
Cr-Commit-Position: refs/heads/master@{#30996}
Patch Set 1 : #
Total comments: 2
Patch Set 2 : #Messages
Total messages: 23 (9 generated)
yurys@chromium.org changed reviewers: + alph@chromium.org
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by yurys@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371253002/60001
https://codereview.chromium.org/1371253002/diff/60001/src/profiler/profile-ge... File src/profiler/profile-generator.cc (right): https://codereview.chromium.org/1371253002/diff/60001/src/profiler/profile-ge... src/profiler/profile-generator.cc:610: pc_entry = code_map_.FindEntry(sample.tos); hmm, isn't the tos contains a copy of what was at SP when the sample was taken. Shouldn't you mark the *SP instead in the sampler?
https://codereview.chromium.org/1371253002/diff/60001/src/profiler/profile-ge... File src/profiler/profile-generator.cc (right): https://codereview.chromium.org/1371253002/diff/60001/src/profiler/profile-ge... src/profiler/profile-generator.cc:610: pc_entry = code_map_.FindEntry(sample.tos); On 2015/09/29 00:04:31, alph wrote: > hmm, isn't the tos contains a copy of what was at SP when the sample was taken. > Shouldn't you mark the *SP instead in the sampler? Good point. Done.
The CQ bit was checked by yurys@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371253002/80001
yurys@chromium.org changed reviewers: + jkummerow@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Jakob can you do OWNERS review?
lgtm
The CQ bit was checked by yurys@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371253002/80001
Message was sent while issue was closed.
Committed patchset #2 (id:80001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4fd8c327de7759aa987869a8933ef5a09a670b34 Cr-Commit-Position: refs/heads/master@{#30996} |