Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1371253002: Tell MSAN that profiler doesn't expect sp to point at initialized memory (Closed)

Created:
5 years, 2 months ago by yurys
Modified:
5 years, 2 months ago
Reviewers:
alph, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Tell MSAN that profiler doesn't expect sp to point at initialized memory BUG=v8:4444, v8:4151 LOG=N Committed: https://crrev.com/4fd8c327de7759aa987869a8933ef5a09a670b34 Cr-Commit-Position: refs/heads/master@{#30996}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/profiler/sampler.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
yurys
5 years, 2 months ago (2015-09-28 19:07:23 UTC) #2
yurys
5 years, 2 months ago (2015-09-29 00:01:42 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371253002/60001
5 years, 2 months ago (2015-09-29 00:02:03 UTC) #8
alph
https://codereview.chromium.org/1371253002/diff/60001/src/profiler/profile-generator.cc File src/profiler/profile-generator.cc (right): https://codereview.chromium.org/1371253002/diff/60001/src/profiler/profile-generator.cc#newcode610 src/profiler/profile-generator.cc:610: pc_entry = code_map_.FindEntry(sample.tos); hmm, isn't the tos contains a ...
5 years, 2 months ago (2015-09-29 00:04:31 UTC) #9
yurys
https://codereview.chromium.org/1371253002/diff/60001/src/profiler/profile-generator.cc File src/profiler/profile-generator.cc (right): https://codereview.chromium.org/1371253002/diff/60001/src/profiler/profile-generator.cc#newcode610 src/profiler/profile-generator.cc:610: pc_entry = code_map_.FindEntry(sample.tos); On 2015/09/29 00:04:31, alph wrote: > ...
5 years, 2 months ago (2015-09-29 00:15:30 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371253002/80001
5 years, 2 months ago (2015-09-29 00:15:43 UTC) #12
yurys
5 years, 2 months ago (2015-09-29 00:18:56 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-29 00:39:04 UTC) #16
alph
lgtm
5 years, 2 months ago (2015-09-29 01:37:42 UTC) #17
yurys
Jakob can you do OWNERS review?
5 years, 2 months ago (2015-09-29 01:57:52 UTC) #18
Jakob Kummerow
lgtm
5 years, 2 months ago (2015-09-29 07:59:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371253002/80001
5 years, 2 months ago (2015-09-29 08:17:09 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 2 months ago (2015-09-29 08:19:02 UTC) #22
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 08:19:10 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4fd8c327de7759aa987869a8933ef5a09a670b34
Cr-Commit-Position: refs/heads/master@{#30996}

Powered by Google App Engine
This is Rietveld 408576698