Source/core/rendering/svg/RenderSVGRoot.cpp - Issue 137123009: Add hittest mode for Touch-action which ignore inline elements and svg elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGRoot.cpp

Issue 137123009: Add hittest mode for Touch-action which ignore inline elements and svg elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RootInlineBox.cpp ('K') | « Source/core/rendering/RootInlineBox.cpp ('k') | Source/web/tests/TouchActionTest.cpp » ('j') | Source/web/tests/TouchActionTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGRoot.cpp

diff --git a/Source/core/rendering/svg/RenderSVGRoot.cpp b/Source/core/rendering/svg/RenderSVGRoot.cpp

old mode 100644

new mode 100755

index bf09427ab301fbc2fb1500fd7e650c7544af74d7..023078abd64ac471539b833eaa2a48fdb23717b1

--- a/Source/core/rendering/svg/RenderSVGRoot.cpp

+++ b/Source/core/rendering/svg/RenderSVGRoot.cpp

@@ -398,7 +398,7 @@ bool RenderSVGRoot::nodeAtPoint(const HitTestRequest& request, HitTestResult& re

// Only test SVG content if the point is in our content box.

// FIXME: This should be an intersection when rect-based hit tests are supported by nodeAtFloatPoint.

- if (contentBoxRect().contains(pointInBorderBox)) {

+ if (!request.touchAction() && contentBoxRect().contains(pointInBorderBox)) {

Rick Byers 2014/01/17 16:12:46 RenderSVGRoot is a RenderBox so whatever we decide

gnana 2014/01/21 14:00:16 commented reply below

FloatPoint localPoint = localToParentTransform().inverse().mapPoint(FloatPoint(pointInParent));

for (RenderObject* child = lastChild(); child; child = child->previousSibling()) {

« Source/core/rendering/RootInlineBox.cpp ('K') | « Source/core/rendering/RootInlineBox.cpp ('k') | Source/web/tests/TouchActionTest.cpp » ('j') | Source/web/tests/TouchActionTest.cpp » ('J')