Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 137123009: Add hittest mode for Touch-action which ignore inline elements and svg elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated review comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderBlock.h ('k') | Source/core/rendering/svg/RenderSVGRoot.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 904 matching lines...) Expand 10 before | Expand all | Expand 10 after
915 915
916 virtual void imageChanged(ImageResource*, const IntRect* = 0) OVERRIDE FINAL ; 916 virtual void imageChanged(ImageResource*, const IntRect* = 0) OVERRIDE FINAL ;
917 virtual void imageChanged(WrappedImagePtr, const IntRect* = 0) { } 917 virtual void imageChanged(WrappedImagePtr, const IntRect* = 0) { }
918 virtual bool willRenderImage(ImageResource*) OVERRIDE FINAL; 918 virtual bool willRenderImage(ImageResource*) OVERRIDE FINAL;
919 919
920 void selectionStartEnd(int& spos, int& epos) const; 920 void selectionStartEnd(int& spos, int& epos) const;
921 921
922 void remove() { if (parent()) parent()->removeChild(this); } 922 void remove() { if (parent()) parent()->removeChild(this); }
923 923
924 bool isInert() const; 924 bool isInert() const;
925 bool visibleToHitTestRequest(const HitTestRequest& request) const { return s tyle()->visibility() == VISIBLE && (request.ignorePointerEventsNone() || style() ->pointerEvents() != PE_NONE) && !isInert(); } 925 virtual bool visibleToHitTestRequest(const HitTestRequest& request) const
926 {
927 if (request.touchAction())
leviw_travelin_and_unemployed 2014/02/28 18:14:39 Instead of making this virtual and adding a branch
gnana 2014/03/03 07:42:31 Done.
928 return false;
929 return style()->visibility() == VISIBLE && (request.ignorePointerEventsN one() || style()->pointerEvents() != PE_NONE) && !isInert();
930 }
931
926 bool visibleToHitTesting() const { return style()->visibility() == VISIBLE & & style()->pointerEvents() != PE_NONE && !isInert(); } 932 bool visibleToHitTesting() const { return style()->visibility() == VISIBLE & & style()->pointerEvents() != PE_NONE && !isInert(); }
927 933
928 // Map points and quads through elements, potentially via 3d transforms. You should never need to call these directly; use 934 // Map points and quads through elements, potentially via 3d transforms. You should never need to call these directly; use
929 // localToAbsolute/absoluteToLocal methods instead. 935 // localToAbsolute/absoluteToLocal methods instead.
930 virtual void mapLocalToContainer(const RenderLayerModelObject* repaintContai ner, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = 0) const; 936 virtual void mapLocalToContainer(const RenderLayerModelObject* repaintContai ner, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = 0) const;
931 virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState&) c onst; 937 virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState&) c onst;
932 938
933 // Pushes state onto RenderGeometryMap about how to map coordinates from thi s renderer to its container, or ancestorToStopAt (whichever is encountered first ). 939 // Pushes state onto RenderGeometryMap about how to map coordinates from thi s renderer to its container, or ancestorToStopAt (whichever is encountered first ).
934 // Returns the renderer which was mapped to (container or ancestorToStopAt). 940 // Returns the renderer which was mapped to (container or ancestorToStopAt).
935 virtual const RenderObject* pushMappingToContainer(const RenderLayerModelObj ect* ancestorToStopAt, RenderGeometryMap&) const; 941 virtual const RenderObject* pushMappingToContainer(const RenderLayerModelObj ect* ancestorToStopAt, RenderGeometryMap&) const;
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
1402 void showTree(const WebCore::RenderObject*); 1408 void showTree(const WebCore::RenderObject*);
1403 void showLineTree(const WebCore::RenderObject*); 1409 void showLineTree(const WebCore::RenderObject*);
1404 void showRenderTree(const WebCore::RenderObject* object1); 1410 void showRenderTree(const WebCore::RenderObject* object1);
1405 // We don't make object2 an optional parameter so that showRenderTree 1411 // We don't make object2 an optional parameter so that showRenderTree
1406 // can be called from gdb easily. 1412 // can be called from gdb easily.
1407 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2); 1413 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);
1408 1414
1409 #endif 1415 #endif
1410 1416
1411 #endif // RenderObject_h 1417 #endif // RenderObject_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBlock.h ('k') | Source/core/rendering/svg/RenderSVGRoot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698