Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: Source/core/rendering/FastTextAutosizer.h

Issue 137123004: Fix treatment of non-autosizing containers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Create a cluster whenever a container toggles autosizing status. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/FastTextAutosizer.h
diff --git a/Source/core/rendering/FastTextAutosizer.h b/Source/core/rendering/FastTextAutosizer.h
index 120d53ca1c0e80e1ddb4411efd7445f46fa4ac70..9dc60aaca3ee118a8798b64a98d517f274200e9e 100644
--- a/Source/core/rendering/FastTextAutosizer.h
+++ b/Source/core/rendering/FastTextAutosizer.h
@@ -67,12 +67,14 @@ public:
private:
struct Cluster {
- explicit Cluster(RenderBlock* root, float multiplier)
+ explicit Cluster(RenderBlock* root, bool autosize, float multiplier)
: m_root(root)
+ , m_autosize(autosize)
, m_multiplier(multiplier)
{
}
RenderBlock* m_root;
+ bool m_autosize;
pdr. 2014/01/14 02:50:03 Can you add a comment here (or above Cluster) that
float m_multiplier;
};
@@ -100,11 +102,10 @@ private:
bool enabled();
void prepareRenderViewInfo(RenderView*);
- bool shouldBeClusterRoot(RenderBlock*);
+ bool isFingerprintingCandidate(RenderBlock*);
bool clusterWantsAutosizing(RenderBlock*);
AtomicString computeFingerprint(RenderBlock*);
- Cluster* getOrCreateCluster(RenderBlock*);
- Cluster* createCluster(RenderBlock*);
+ Cluster* maybeGetOrCreateCluster(RenderBlock*);
Cluster* addSupercluster(AtomicString, RenderBlock*);
RenderBlock* deepestCommonAncestor(BlockSet&);
float computeMultiplier(RenderBlock*);
« no previous file with comments | « no previous file | Source/core/rendering/FastTextAutosizer.cpp » ('j') | Source/core/rendering/FastTextAutosizer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698