Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1861)

Unified Diff: runtime/vm/object.cc

Issue 1371193005: VM restart + shutdown fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: more code review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/port_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 49f50601c7b302fbbce61b353af80181797fe73b..87f3f10716e4d77dc1ddfc5b41747256f9c4c79a 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -14315,9 +14315,10 @@ RawUnwindError* UnwindError::New(const String& message, Heap::Space space) {
space);
NoSafepointScope no_safepoint;
result ^= raw;
- result.StoreNonPointer(&result.raw_ptr()->is_user_initiated_, false);
}
result.set_message(message);
+ result.set_is_user_initiated(false);
+ result.set_is_vm_restart(false);
return result.raw();
}
@@ -14332,6 +14333,11 @@ void UnwindError::set_is_user_initiated(bool value) const {
}
+void UnwindError::set_is_vm_restart(bool value) const {
+ StoreNonPointer(&raw_ptr()->is_vm_restart_, value);
+}
+
+
const char* UnwindError::ToErrorCString() const {
const String& msg_str = String::Handle(message());
return msg_str.ToCString();
@@ -14349,6 +14355,8 @@ void UnwindError::PrintJSONImpl(JSONStream* stream, bool ref) const {
jsobj.AddProperty("kind", "TerminationError");
jsobj.AddServiceId(*this);
jsobj.AddProperty("message", ToErrorCString());
+ jsobj.AddProperty("_is_user_initiated", is_user_initiated());
+ jsobj.AddProperty("_is_vm_restart", is_vm_restart());
}
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/port_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698