runtime/observatory/lib/src/service/object.dart - Issue 1371193005: VM restart + shutdown fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1371193005: VM restart + shutdown fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: more code review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/service/object.dart

diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart

index 2ca18b3787b5e6a7444f7e14bdc315177d4eff69..e65f5b76534045ecccc215c830d6b955232c7902 100644

--- a/runtime/observatory/lib/src/service/object.dart

+++ b/runtime/observatory/lib/src/service/object.dart

@@ -803,6 +803,10 @@ abstract class VM extends ServiceObjectOwner {

}

+ Future restart() {

+ return invokeRpc('_restartVM', {});

+ }

Future<ObservableMap> _fetchDirect() async {

if (!loaded) {

// The vm service relies on these events to keep the VM and