runtime/vm/service_isolate.cc - Issue 1371193005: VM restart + shutdown fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service_isolate.cc

Issue 1371193005: VM restart + shutdown fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: code review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/service_isolate.cc

diff --git a/runtime/vm/service_isolate.cc b/runtime/vm/service_isolate.cc

index c07638fcd9fccccaeb512feb613b40421f7fc43b..1a6fe055761a5b833eea817df453effb4c09cc9e 100644

--- a/runtime/vm/service_isolate.cc

+++ b/runtime/vm/service_isolate.cc

@@ -770,7 +770,7 @@ void ServiceIsolate::KillServiceIsolate() {

MonitorLocker ml(monitor_);

shutting_down_ = true;

}

- Isolate::KillIfExists(isolate_);

+ Isolate::KillIfExists(isolate_, Isolate::kInternalKillMsg);

{

MonitorLocker ml(monitor_);

while (shutting_down_) {