Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: runtime/vm/isolate.h

Issue 1371193005: VM restart + shutdown fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix ups Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 422e4d0ab1dc715863b3fa665a2b31d2247678b9..3d14a2fd86d23a0b3c598b14a7cf8f7c21b25a30 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -129,6 +129,7 @@ class Isolate : public BaseIsolate {
// Internal message ids.
kInterruptMsg = 10, // Break in the debugger.
kInternalKillMsg = 11, // Like kill, but does not run exit listeners, etc.
+ kVMRestartMsg = 12, // Sent to isolates when vm is restarting.
};
// The different Isolate API message priorities for ping and kill messages.
enum LibMsgPriority {
@@ -766,6 +767,9 @@ class Isolate : public BaseIsolate {
bool is_service_isolate() const { return is_service_isolate_; }
+ // The isolates_list_monitor_ should be held when calling Kill().
+ void KillLocked(LibMsgId msg_id = kInternalKillMsg);
zra 2015/10/05 16:56:47 Maybe instead of making this public, make RestartV
Cutch 2015/10/05 18:10:46 +1 to suggestion of dropping default msg_id value.
turnidge 2015/10/05 22:18:24 I have made this private again. I have added a ms
+
static void KillAllIsolates();
static void KillIfExists(Isolate* isolate);
@@ -783,9 +787,6 @@ class Isolate : public BaseIsolate {
const Dart_IsolateFlags& api_flags,
bool is_vm_isolate = false);
- // The isolates_list_monitor_ should be held when calling Kill().
- void KillLocked();
-
void LowLevelShutdown();
void Shutdown();
void ReclaimTimelineBlocks();

Powered by Google App Engine
This is Rietveld 408576698