Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: runtime/vm/service_isolate.cc

Issue 1371193005: VM restart + shutdown fixes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service_isolate.h" 5 #include "vm/service_isolate.h"
6 6
7 #include "vm/compiler.h" 7 #include "vm/compiler.h"
8 #include "vm/dart_api_impl.h" 8 #include "vm/dart_api_impl.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/isolate.h" 10 #include "vm/isolate.h"
(...skipping 752 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 763
764 764
765 void ServiceIsolate::KillServiceIsolate() { 765 void ServiceIsolate::KillServiceIsolate() {
766 if (!FLAG_shutdown) { 766 if (!FLAG_shutdown) {
767 return; 767 return;
768 } 768 }
769 { 769 {
770 MonitorLocker ml(monitor_); 770 MonitorLocker ml(monitor_);
771 shutting_down_ = true; 771 shutting_down_ = true;
772 } 772 }
773 Isolate::KillIfExists(isolate_); 773 Isolate::KillIfExists(isolate_, Isolate::kInternalKillMsg);
774 { 774 {
775 MonitorLocker ml(monitor_); 775 MonitorLocker ml(monitor_);
776 while (shutting_down_) { 776 while (shutting_down_) {
777 ml.Wait(); 777 ml.Wait();
778 } 778 }
779 } 779 }
780 } 780 }
781 781
782 782
783 void ServiceIsolate::Shutdown() { 783 void ServiceIsolate::Shutdown() {
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
845 return result; 845 return result;
846 } 846 }
847 Dart_Handle source = GetSource(url_string); 847 Dart_Handle source = GetSource(url_string);
848 if (Dart_IsError(source)) { 848 if (Dart_IsError(source)) {
849 return source; 849 return source;
850 } 850 }
851 return Dart_LoadSource(library, url, source, 0, 0); 851 return Dart_LoadSource(library, url, source, 0, 0);
852 } 852 }
853 853
854 } // namespace dart 854 } // namespace dart
OLDNEW
« runtime/vm/isolate.cc ('K') | « runtime/vm/service.cc ('k') | runtime/vm/service_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698