Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1371193003: exclude PhishingDOMFeatureExtractorTest.* browser_tests on Dr. Memory bots (Closed)

Created:
5 years, 2 months ago by zhaoqin1
Modified:
5 years, 2 months ago
Reviewers:
erikchen
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exclude PhishingDOMFeatureExtractorTest.* browser_tests on Dr. Memory bots TBR=erikchen@chromium.org BUG=536891 NOTRY=true Committed: https://crrev.com/2b4bfec5eab7ab8986557934ef9bd27e87c8e22b Cr-Commit-Position: refs/heads/master@{#351107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
zhaoqin1
5 years, 2 months ago (2015-09-28 18:31:16 UTC) #1
erikchen
On 2015/09/28 18:31:16, zhaoqin1 wrote: Why was a tbr-ed on this CL?
5 years, 2 months ago (2015-09-28 18:36:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371193003/1
5 years, 2 months ago (2015-09-28 18:37:35 UTC) #4
zhaoqin1
On 2015/09/28 18:36:48, erikchen wrote: > On 2015/09/28 18:31:16, zhaoqin1 wrote: > > Why was ...
5 years, 2 months ago (2015-09-28 18:40:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 19:25:34 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2b4bfec5eab7ab8986557934ef9bd27e87c8e22b Cr-Commit-Position: refs/heads/master@{#351107}
5 years, 2 months ago (2015-09-28 19:27:05 UTC) #7
erikchen
5 years, 2 months ago (2015-09-28 20:26:11 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1375743002/ by erikchen@chromium.org.

The reason for reverting is: I'm reverting the relevant CL,
https://codereview.chromium.org/1373993002/

so this exclusion is no longer necessary..

Powered by Google App Engine
This is Rietveld 408576698