Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1371163002: Fix output surface Memory Dump Provider unregistration. (Closed)

Created:
5 years, 2 months ago by ericrk
Modified:
5 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix output surface Memory Dump Provider unregistration. The memory dump provider for OutputSurface was registered on the client thread, but could be unregistered on the main thread in cases when the client was cleaned up before the destructor was called (very common). Move the unregistration code to the parallel of the registration code, so that both only when appropriate, on the client thread. BUG=536824 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/1fd62112fb543ccf8fe9af896cf09142ad06c4ec Cr-Commit-Position: refs/heads/master@{#351176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M cc/output/output_surface.cc View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ericrk
5 years, 2 months ago (2015-09-28 17:55:36 UTC) #2
reveman
lgtm
5 years, 2 months ago (2015-09-28 18:04:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371163002/1
5 years, 2 months ago (2015-09-28 18:13:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
5 years, 2 months ago (2015-09-28 20:17:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371163002/1
5 years, 2 months ago (2015-09-28 21:52:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 22:39:33 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:40:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fd62112fb543ccf8fe9af896cf09142ad06c4ec
Cr-Commit-Position: refs/heads/master@{#351176}

Powered by Google App Engine
This is Rietveld 408576698