Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1371153005: Mov Linux & Mac GN compiler flags to separate configs. (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Bons
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mov Linux & Mac GN compiler flags to separate configs. This is another step in cleaning up the giant generic compiler config. Committed: https://crrev.com/0babe10ea56d503a699627eb91bdd3b62de8f201 Cr-Commit-Position: refs/heads/master@{#352377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -43 lines) Patch
M build/config/compiler/BUILD.gn View 3 chunks +5 lines, -43 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M build/config/mac/BUILD.gn View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371153005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371153005/1
5 years, 2 months ago (2015-10-05 16:54:33 UTC) #3
Bons
lgtm
5 years, 2 months ago (2015-10-05 17:51:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371153005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371153005/1
5 years, 2 months ago (2015-10-05 18:02:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 19:10:05 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 19:10:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0babe10ea56d503a699627eb91bdd3b62de8f201
Cr-Commit-Position: refs/heads/master@{#352377}

Powered by Google App Engine
This is Rietveld 408576698