Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1371103002: platformKeys: Document supported algorithms and hash functions. (Closed)

Created:
5 years, 2 months ago by pneubeck (no reviews)
Modified:
5 years, 2 months ago
Reviewers:
Mike West
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

platformKeys: Document supported algorithms and hash functions. Committed: https://crrev.com/7a9f2913d90fd30473664eb02dd6cabc910d8b2c Cr-Commit-Position: refs/heads/master@{#351066}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/common/extensions/api/platform_keys.idl View 1 chunk +10 lines, -7 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
pneubeck (no reviews)
could you take a look at this documentation-only change? https://codereview.chromium.org/1371103002/diff/1/chrome/common/extensions/api/platform_keys.idl File chrome/common/extensions/api/platform_keys.idl (left): https://codereview.chromium.org/1371103002/diff/1/chrome/common/extensions/api/platform_keys.idl#oldcode123 chrome/common/extensions/api/platform_keys.idl:123: ...
5 years, 2 months ago (2015-09-28 13:22:26 UTC) #2
Mike West
LGTM
5 years, 2 months ago (2015-09-28 13:27:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371103002/1
5 years, 2 months ago (2015-09-28 13:38:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 14:13:00 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 14:13:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a9f2913d90fd30473664eb02dd6cabc910d8b2c
Cr-Commit-Position: refs/heads/master@{#351066}

Powered by Google App Engine
This is Rietveld 408576698